Closed
Bug 466257
Opened 17 years ago
Closed 17 years ago
Workers: Errors in sub workers aren't propagated to top-most parents like they should
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b3
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
23.48 KB,
patch
|
sicking
:
review+
sicking
:
superreview+
|
Details | Diff | Splinter Review |
Currently if you make worker A, it makes worker B, and B throws an exception, you won't see the exception unless A explicitly rethrows it. This is wrong.
Comment 1•17 years ago
|
||
Changing this later if we release what we have would be a major headache for developers as they could start getting exceptions thrown where none were thrown in earlier versions. We really should fix this before releasing 3.1. Marking blocking.
Flags: blocking1.9.1+
Assignee | ||
Comment 2•17 years ago
|
||
First stab. Errors from child workers keep propagating until preventDefault is called on the error event. Also, if there is no error listener defined on the top-level worker then the exception is logged to the JS console.
Attachment #349835 -
Flags: superreview?(jonas)
Attachment #349835 -
Flags: review?(jonas)
Comment on attachment 349835 [details] [diff] [review]
Patch, v1
Remove the !hasListener check. With that r/sr=me
Attachment #349835 -
Flags: superreview?(jonas)
Attachment #349835 -
Flags: superreview+
Attachment #349835 -
Flags: review?(jonas)
Attachment #349835 -
Flags: review+
Comment 4•17 years ago
|
||
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b3
Updated•17 years ago
|
Keywords: fixed1.9.1
Updated•12 years ago
|
Component: DOM: Mozilla Extensions → DOM
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•