Closed
Bug 466302
Opened 16 years ago
Closed 16 years ago
remove superfluous inclusion of global/skin in editMenuOverlay
Categories
(Toolkit :: UI Widgets, defect)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla1.9.1
People
(Reporter: kairo, Assigned: kairo)
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
590 bytes,
patch
|
Gavin
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
A reference like http://hg.mozilla.org/mozilla-central/file/tip/toolkit/content/editMenuOverlay.xul#l2 shouldn't be made in an overlay, as global/skin should be included by any .xul file itself already.
This effectively hinders SeaMonkey from using that overlay, as it overwrites our redefinitions of e.g. the <toolbar> binding to use grippies (via communicator/skin) due to the last CSS definition being the one used.
Assignee | ||
Comment 1•16 years ago
|
||
This patch just removes it. I didn't see any breakage in Firefox with this patch, but I only did fast checking in a few windows, as I'm not using FF daily.
Attachment #349578 -
Flags: review?(gavin.sharp)
Updated•16 years ago
|
Attachment #349578 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 2•16 years ago
|
||
Pushed as http://hg.mozilla.org/mozilla-central/rev/b1ef40eefe8f on trunk.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•16 years ago
|
Attachment #349578 -
Flags: approval1.9.1?
Comment 3•16 years ago
|
||
Comment on attachment 349578 [details] [diff] [review]
just remove it
a191=beltzner
Attachment #349578 -
Flags: approval1.9.1? → approval1.9.1+
Assignee | ||
Comment 4•16 years ago
|
||
Pushed to 1.9.1 as http://hg.mozilla.org/releases/mozilla-1.9.1/rev/56f70f781cad
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•