Closed Bug 466302 Opened 16 years ago Closed 16 years ago

remove superfluous inclusion of global/skin in editMenuOverlay

Categories

(Toolkit :: UI Widgets, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.1

People

(Reporter: kairo, Assigned: kairo)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

A reference like http://hg.mozilla.org/mozilla-central/file/tip/toolkit/content/editMenuOverlay.xul#l2 shouldn't be made in an overlay, as global/skin should be included by any .xul file itself already. This effectively hinders SeaMonkey from using that overlay, as it overwrites our redefinitions of e.g. the <toolbar> binding to use grippies (via communicator/skin) due to the last CSS definition being the one used.
Attached patch just remove itSplinter Review
This patch just removes it. I didn't see any breakage in Firefox with this patch, but I only did fast checking in a few windows, as I'm not using FF daily.
Attachment #349578 - Flags: review?(gavin.sharp)
Attachment #349578 - Flags: review?(gavin.sharp) → review+
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Attachment #349578 - Flags: approval1.9.1?
Comment on attachment 349578 [details] [diff] [review] just remove it a191=beltzner
Attachment #349578 - Flags: approval1.9.1? → approval1.9.1+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: