Closed
Bug 466303
Opened 17 years ago
Closed 17 years ago
When removing bookmark backups remove also old html ones
Categories
(Firefox :: Bookmarks & History, defect, P2)
Firefox
Bookmarks & History
Tracking
()
VERIFIED
FIXED
Firefox 3.1b3
People
(Reporter: mak, Assigned: mak)
References
Details
(Keywords: verified1.9.1)
Attachments
(1 file)
|
5.27 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
the removal regexp only catch .json files, it should also catch old .html backup files
|
Assignee | |
Updated•17 years ago
|
OS: Windows Vista → All
Hardware: PC → All
|
|
Assignee | |
Comment 1•17 years ago
|
||
> bug 445704 has a regular expression that culls html files from the list of
> files to be purged when archiving bookmarks.
>
> this is a regression that should be fixed for 3.1 final, as it's a potential
> privacy exposure to leave ancient bookmarks.html backups laying around forever.
|
|
Assignee | |
Comment 2•17 years ago
|
||
comment 1 is from dietrich
Flags: blocking-firefox3.1?
Summary: When removing bookmark backup remove also old html ones → When removing bookmark backups remove also old html ones
|
||
Updated•17 years ago
|
Flags: blocking-firefox3.1? → blocking-firefox3.1+
Priority: -- → P2
Target Milestone: --- → Firefox 3.1
|
|
Assignee | |
Updated•17 years ago
|
Assignee: nobody → mak77
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•17 years ago
|
||
Attachment #351212 -
Flags: review?(dietrich)
|
|
Assignee | |
Updated•17 years ago
|
Flags: in-testsuite?
|
|
Assignee | |
Updated•17 years ago
|
Whiteboard: [has patch][needs review dietrich]
|
|
||
Comment 5•17 years ago
|
||
Comment on attachment 351212 [details] [diff] [review]
patch with test
r=me, thanks!
Attachment #351212 -
Flags: review?(dietrich) → review+
|
|
||
Updated•17 years ago
|
Whiteboard: [has patch][needs review dietrich] → [has patch][has review]
|
|
Assignee | |
Comment 6•17 years ago
|
||
pushed to trunk:
http://hg.mozilla.org/mozilla-central/rev/bc60bbab6efd
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite? → in-testsuite+
Resolution: --- → FIXED
|
|
Assignee | |
Comment 7•17 years ago
|
||
pushed to 1.9.1 branch:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9ced7ea695e8
Keywords: fixed1.9.1
Whiteboard: [has patch][has review]
Target Milestone: Firefox 3.1 → Firefox 3.1b3
|
||
Comment 8•17 years ago
|
||
verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090127 Shiretoko/3.1b3pre
Keywords: fixed1.9.1 → verified1.9.1
|
|
||
Updated•17 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•