Closed Bug 466564 Opened 16 years ago Closed 16 years ago

RemoveDuplicateURIs is not aware of temp views

Categories

(Toolkit :: Places, defect)

defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: mak, Assigned: mak)

References

Details

(Keywords: fixed1.9.1, regression)

Attachments

(1 file)

RemoveDuplicateURIs uses our temporary views, but at the time it is called by migrateV6Up, those do not still exist!
So the queries (and migration) will fail.

Should affect migrations from Firefox3b2 -> 3.1
Flags: blocking1.9.1?
Do you mean it will affect anyone migrating from that specific milestone, or anyone who *started* using Firefox 3 at Beta 2?
the former, no exactly an hard blocker because they could be a really small number (ideally 0) but migration should work.
Keywords: regression
We'll take a safe fix, but for 10k users, this don't block.
Flags: blocking1.9.1? → blocking1.9.1-
targeting to have on the radar, not hard to fix if we'll have time to do that, thanks
Target Milestone: --- → mozilla1.9.1
Attached patch patch v1Splinter Review
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attachment #354154 - Flags: review?(dietrich)
Attachment #354154 - Flags: review?(dietrich) → review+
http://hg.mozilla.org/mozilla-central/rev/5d6081dd83d0
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9.1 → mozilla1.9.2a1
Comment on attachment 354154 [details] [diff] [review]
patch v1

asking approval, this should be a no risk, will involve direct upgrade from a 3.0beta to 3.1
Attachment #354154 - Flags: approval1.9.1?
Comment on attachment 354154 [details] [diff] [review]
patch v1

a191=beltzner
Attachment #354154 - Flags: approval1.9.1? → approval1.9.1+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: