Closed
Bug 466564
Opened 16 years ago
Closed 16 years ago
RemoveDuplicateURIs is not aware of temp views
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: mak, Assigned: mak)
References
Details
(Keywords: fixed1.9.1, regression)
Attachments
(1 file)
3.37 KB,
patch
|
dietrich
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
RemoveDuplicateURIs uses our temporary views, but at the time it is called by migrateV6Up, those do not still exist! So the queries (and migration) will fail. Should affect migrations from Firefox3b2 -> 3.1
Flags: blocking1.9.1?
Comment 1•16 years ago
|
||
Do you mean it will affect anyone migrating from that specific milestone, or anyone who *started* using Firefox 3 at Beta 2?
Assignee | ||
Comment 2•16 years ago
|
||
the former, no exactly an hard blocker because they could be a really small number (ideally 0) but migration should work.
Assignee | ||
Updated•16 years ago
|
Keywords: regression
Comment 3•16 years ago
|
||
We'll take a safe fix, but for 10k users, this don't block.
Flags: blocking1.9.1? → blocking1.9.1-
Assignee | ||
Comment 4•16 years ago
|
||
targeting to have on the radar, not hard to fix if we'll have time to do that, thanks
Target Milestone: --- → mozilla1.9.1
Assignee | ||
Comment 5•16 years ago
|
||
Updated•16 years ago
|
Attachment #354154 -
Flags: review?(dietrich) → review+
Comment 6•16 years ago
|
||
Comment on attachment 354154 [details] [diff] [review] patch v1 r=me
Assignee | ||
Comment 7•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/5d6081dd83d0
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9.1 → mozilla1.9.2a1
Assignee | ||
Comment 8•16 years ago
|
||
Comment on attachment 354154 [details] [diff] [review] patch v1 asking approval, this should be a no risk, will involve direct upgrade from a 3.0beta to 3.1
Attachment #354154 -
Flags: approval1.9.1?
Comment 9•15 years ago
|
||
Comment on attachment 354154 [details] [diff] [review] patch v1 a191=beltzner
Attachment #354154 -
Flags: approval1.9.1? → approval1.9.1+
Comment 10•15 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c7e291d1f9d2
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•