Closed Bug 466598 Opened 17 years ago Closed 17 years ago

Wave decoder crash when attempting to seek past the end of the file

Categories

(Core :: Audio/Video, defect, P2)

Product:
Core
Component:
Audio/Video
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1b3

People

(Reporter: kinetik, Assigned: kinetik)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

patch v1 [Checkin: Comment 2 & 3]
4.77 KB, patch
roc
: review+
roc
: superreview+
Details | Diff | Splinter Review
The media spec states that attempting to seek to a position before the first valid position should seek to the first valid position, and that attempting to seek to a position beyond the last valid position should seek to the last valid position. The Wave decoder erroneously rejects the former case, and crashes due to a missing range check in the latter case.
Fix these cases, plus also fix a related case I found, where seeking to the end of the media would cause currentTime to report bogus values.
Attachment #349909 - Flags: superreview?(roc)
Attachment #349909 - Flags: review?(roc)
Flags: blocking1.9.1?
Attachment #349909 - Flags: superreview?(roc)
Attachment #349909 - Flags: superreview+
Attachment #349909 - Flags: review?(roc)
Attachment #349909 - Flags: review+
Flags: blocking1.9.1? → blocking1.9.1+
Whiteboard: [needs landing]
Pushed to trunk as 72f035f76b66
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [needs landing] → [needs 191 landing]
Comment on attachment 349909 [details] [diff] [review] patch v1 [Checkin: Comment 2 & 3] http://hg.mozilla.org/releases/mozilla-1.9.1/rev/4379539c6c7a
Attachment #349909 - Attachment description: patch v1 → patch v1 [Checkin: Comment 2 & 3]
Keywords: checkin-needed → fixed1.9.1
Whiteboard: [needs 191 landing]
Target Milestone: --- → mozilla1.9.1b3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: