466751 - setting .innerHTML to invalid markup in XHTML causes NS_ERROR_INVALID_POINTER

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[jqrusr.7.n1]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.4) Gecko/2008111318 Ubuntu/8.10 (intrepid) Firefox/3.0.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.4) Gecko/2008111318 Ubuntu/8.10 (intrepid) Firefox/3.0.4

The error that occurs when one sets .innerHTML to something that is not valid XHTML is very cryptic and does not hint at all at the cause of the error, making it very hard to find the source of the problem.

Reproducible: Always

Steps to Reproduce:
1. create a document that is used in XHMTL standards mode
2. have it include a javascript function that sets invalid markup (e.g. foo.innerHTML = '<div ">';

Actual Results:  
uncaught exception: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIDOMNSHTMLElement.innerHTML]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: file://... :: <TOP_LEVEL> :: line 15"  data: no]

Line 0

Expected Results:  
A better error message or anything else that's more useful.

Comment 1

[jqrusr.7.n1]

Attachment: a testcase. remove the doublequote in line 15 to make it valid

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

The other caller of this method (nsRange::CreateContextualFragment) can already fail, so I think this should be OK.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

That patch results in us throwing:
Error: uncaught exception: [Exception... "An invalid or illegal string was specified"  code: "12" nsresult: "0x8053000c (NS_ERROR_DOM_SYNTAX_ERR)"  location: "https://bugzilla.mozilla.org/attachment.cgi?id=350091 Line: 15"]

Either way we show a "not well formed" error in addition to the innerHTML exception, as far as I can tell, so this isn't *too* big of a deal.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: with test

Comment 5

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/e81a52c40a43