466893 - Prism 0.9.1 broken in Minefield/3.1b3pre

Status: RESOLVED FIXED

(Mozilla Labs :: Prism, defect)

Description

[Stanimir Angeloff]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081126 Minefield/3.1b3pre FireShot/0.32
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081126 Minefield/3.1b3pre Prism/0.9.1

A while back Minefield introduced native JSON.encode and JSON.decode support. Prism is still making use of resource://gre/modules/JSON.jsm which throws an exception during start up.

Reproducible: Always

Steps to Reproduce:
1. Install Minefield/3.1b3pre
2. Download Prism 0.9.1 and hack install.rdf to support Minefield/3.1b3pre
3. Install Prism into Minefield
4. Create a webapp and launch it
Actual Results:  
A new window appears with Firefox default app chrome.


Prism does NOT officially support Minefield/3.1b3pre

Comment 1

[Stanimir Angeloff]

Attachment: Patch to add support for Minefield/3.1b3pre

Tested on MS Windows XP using GnuWin32 patch.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: alternate patch

This patch uses nsIJSON which works in 1.9.0 and 1.9.1

Comment 3

[Antonio Gomes (tonikitoo)]

same on linux. so assuming "Platform: All"

mark, you forgot "-w" for the patch.

Comment 4

[Matthew Gertner]

Comment on attachment 350430 [details] [diff] [review]
alternate patch

I'll try to figure out some way to get some sort of sane whitespace behavior in my editing environments since that is what is causing the noise in Mark's patches.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Sending content: E:\mozilla-sdk-cvs\mozilla\prism\runtime\chrome\content\webrunner.js  
Completed: At revision: 20520