466984 - SM l10n win build machine fails to generate .zip and .mar files

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Vlado Valastiak [:wladow]]

Since landing bug 464921 there are no l10n win .zip and .mar files

Tinderbox log (sk) - Win2k3 comm-central l10n seamonkey on 2008/11/27 02:54:42:
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n-sk/1227783282.1227784997.14032.gz

Comment 1

[Robert Kaiser]

Attachment: copy instead of move extension langpacks (checked in)

This part solves the problem of failing zip generation - we're now (after bug 464921) only building the locale once and using it for both installer and zip, so the installer repackaging step needs to copy it instead of moving it away, or else the zip step fails because it's not finding the langpack in xpi-stage.

Comment 2

[:Gijs (out for now; he/him)]

Why the -r? It's a file, right? You don't need to copy things recursively... Am I missing something?

Comment 3

[Robert Kaiser]

oh, sure, I dumbly copied the cp -r from somewhere else - I'll check it in without the -r if you review it :)

Comment 4

[:Gijs (out for now; he/him)]

Comment on attachment 350333 [details] [diff] [review]
copy instead of move extension langpacks (checked in)

OK, r=me with removing the -r :-)

Comment 5

[Robert Kaiser]

Uh, actually, I just looked at this again, and we're not copying the .xpi - that wouldn't actually work in a ready-packaged build. We're copying the contents of the xpi-stage/$(XPI_NAME)/ directory, so the -r actually _is_ correct!

Comment 6

[:Gijs (out for now; he/him)]

(In reply to comment #5)
> Uh, actually, I just looked at this again, and we're not copying the .xpi -
> that wouldn't actually work in a ready-packaged build. We're copying the
> contents of the xpi-stage/$(XPI_NAME)/ directory, so the -r actually _is_
> correct!

Hrmpf, r=me anyway, then - thanks for clarifying.

Comment 7

[Robert Kaiser]

Attachment: update MAR generation for comm-central builds

This patch updates the MAR generation part, basically a straight port of bug 466894.
Gozer, handing this to you for review, as we need to update our L10n buildbots to 1) hand MOZ_MAKE_COMPLETE_MAR=1 to the installers-* step and 2) remove the extra step for MAR generation - at least if you also have support for L10n MARs in your buildbot (I'm not sure).

Comment 8

[Robert Kaiser]

Comment on attachment 350333 [details] [diff] [review]
copy instead of move extension langpacks (checked in)

The ChatZilla/venkman part is in - thanks, Gijs!

Comment 9

[Philippe M. Chiasson (:gozer)]

(In reply to comment #7)
>
> Gozer, handing this to you for review, as we need to update our L10n buildbots
> to 1) hand MOZ_MAKE_COMPLETE_MAR=1 to the installers-* step 

Done for thunderbird buildbots

> and 2) remove the
> extra step for MAR generation - at least if you also have support for L10n MARs
> in your buildbot (I'm not sure).

Done for thunderbird buildbots too.

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 350351 [details] [diff] [review]
update MAR generation for comm-central builds

a=me for SM 2.0a2 and TB 3.0b1

I think we should take this as we'll want it for nightly builds (I guess) and we'll probably need it if we decide to do updates from alpha 3 (which I think we aren't but just in case).

Also it shouldn't have an adverse effect on the main build anyway.

Comment 11

[Robert Kaiser]

MAR fix pushed as http://hg.mozilla.org/comm-central/rev/6a2107f99390 - me and gozer are updating the buildbots for this as well as I'm writing this.

With that, I hope we'll have fixed those builds.