Closed
Bug 466996
Opened 15 years ago
Closed 15 years ago
Implement single / plural form in alarmWindowTitle
Categories
(Calendar :: Alarms, defect)
Calendar
Alarms
Tracking
(Not tracked)
RESOLVED
FIXED
1.0b1
People
(Reporter: Tonnes, Assigned: wladow)
Details
Attachments
(2 files)
1.83 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
1.74 KB,
patch
|
Details | Diff | Splinter Review |
Currently, alarmWindowTitle displays as ‘2 Reminders’ when there are 2 or more reminders, and ‘1 Reminder’ when there is only one. It would be nice if ‘1 Reminder’ was displayed in case there is only one, or ‘Reminder(s)’ at least if pluralform cannot be implemented.
Updated•15 years ago
|
Severity: normal → minor
OS: Windows 2000 → All
Hardware: PC → All
Comment 1•15 years ago
|
||
Just FYI, other locales have different rules for plurals, and hence why PluralForm would be a good candidate here! Could also pave the way for "One Reminder" || "2 Reminders" etc. see: http://developer.mozilla.org/en/docs/Localization_and_Plurals
Reporter | ||
Comment 2•15 years ago
|
||
(In reply to comment #0) > .. 2 or more reminders, and ‘1 Reminder’ when there is only one. Sorry, I meant ‘1 Reminders’, of course.
Severity: minor → normal
OS: All → Windows 2000
Hardware: All → PC
Assignee | ||
Comment 3•15 years ago
|
||
This adds pluralForm support as mentioned in comment #1
Assignee | ||
Updated•15 years ago
|
OS: Windows 2000 → All
Hardware: PC → All
Comment 4•15 years ago
|
||
Comment on attachment 350370 [details] [diff] [review] add PluralForm v1 >diff --git a/calendar/locales/en-US/chrome/calendar/calendar.properties b/calendar/locales/en-US/chrome/calendar/calendar.properties >--- a/calendar/locales/en-US/chrome/calendar/calendar.properties >+++ b/calendar/locales/en-US/chrome/calendar/calendar.properties >@@ -1,3 +1,4 @@ >+ > # ***** BEGIN LICENSE BLOCK ***** > # Version: MPL 1.1/GPL 2.0/LGPL 2.1 > # No need for initial newline. r=philipp with first hunk removed.
Attachment #350370 -
Flags: review?(philipp) → review+
Comment 5•15 years ago
|
||
Checkin needed with comments considered, I'll do so in the next days as I have time.
Keywords: checkin-needed
Assignee | ||
Comment 6•15 years ago
|
||
heh, sure, I'm just wondering how did that happen :)
Comment 7•15 years ago
|
||
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/d88b39fbf697> -> FIXED
Comment 8•12 years ago
|
||
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•