466996 - Implement single / plural form in alarmWindowTitle

Status: RESOLVED FIXED

(Calendar :: Alarms, defect)

Description

[Ton [:Tonnes]]

Currently, alarmWindowTitle displays as ‘2 Reminders’ when there are 2 or more reminders, and ‘1 Reminder’ when there is only one. It would be nice if ‘1 Reminder’ was displayed in case there is only one, or ‘Reminder(s)’ at least if pluralform cannot be implemented.

Comment 1

[Justin Wood (:Callek)]

Just FYI, other locales have different rules for plurals, and hence why PluralForm would be a good candidate here!

Could also pave the way for "One Reminder" || "2 Reminders" etc.

see: http://developer.mozilla.org/en/docs/Localization_and_Plurals

Comment 2

[Ton [:Tonnes]]

(In reply to comment #0)
 
> .. 2 or more reminders, and ‘1 Reminder’ when there is only one.

Sorry, I meant ‘1 Reminders’, of course.

Comment 3

[Vlado Valastiak [:wladow]]

Attachment: add PluralForm v1

This adds pluralForm support as mentioned in comment #1

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 350370 [details] [diff] [review]
add PluralForm v1 

>diff --git a/calendar/locales/en-US/chrome/calendar/calendar.properties b/calendar/locales/en-US/chrome/calendar/calendar.properties
>--- a/calendar/locales/en-US/chrome/calendar/calendar.properties
>+++ b/calendar/locales/en-US/chrome/calendar/calendar.properties
>@@ -1,3 +1,4 @@
>+
> # ***** BEGIN LICENSE BLOCK *****
> # Version: MPL 1.1/GPL 2.0/LGPL 2.1
> #
No need for initial newline.

r=philipp with first hunk removed.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Checkin needed with comments considered, I'll do so in the next days as I have time.

Comment 6

[Vlado Valastiak [:wladow]]

Attachment: for checkin

heh, sure, I'm just wondering how did that happen :)

Comment 7

[Martin Schröder [:mschroeder]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/d88b39fbf697>

-> FIXED

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".