Closed Bug 467118 Opened 13 years ago Closed 7 years ago

Switch Integrated Search indexing over to use nsIIdleService instead of message displayed timers

Categories

(MailNews Core :: Search, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0a3

People

(Reporter: rain1, Assigned: rain1)

References

()

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch patch + other related cleanup v1 (obsolete) — Splinter Review
Other cleanup:
- removed restartTimer() as we didn't need it at all except for one place
- renamed onTimer to _continueSweep
Assignee: nobody → sid1337
Status: NEW → ASSIGNED
Attachment #350673 - Flags: review?(bienvenu)
Attachment #350673 - Flags: superreview?(beckley)
Attachment #350673 - Flags: superreview?(beckley) → review?(beckley)
Comment on attachment 350673 [details] [diff] [review]
patch + other related cleanup v1

Looks fine
Attachment #350673 - Flags: review?(beckley) → review+
Comment on attachment 350673 [details] [diff] [review]
patch + other related cleanup v1

very cool, thx for doing this - but, if we're idle, I would think we could be much more aggressive about our timer, if I'm understanding the code correctly...
Attachment #350673 - Flags: review?(bienvenu) → review+
David: yes, that should be possible. The throttling with this patch is the same as the throttling without, though.

I'll leave this bug open, and I can revisit it once a couple of other patches in my queue get in.
Attachment #350673 - Attachment is obsolete: true
Attachment #351702 - Flags: superreview+
Attachment #351702 - Flags: review+
Attachment #351702 - Flags: superreview+
Keywords: checkin-needed
Comment on attachment 351702 [details] [diff] [review]
patch (no changes, but to pre-empt any possible bitrot)
[Checkin: Comment 5]

http://hg.mozilla.org/comm-central/rev/db341efa61d3
Attachment #351702 - Attachment description: patch (no changes, but to pre-empt any possible bitrot) → patch (no changes, but to pre-empt any possible bitrot) [Checkin: Comment 5]
sid, is this perf related?
Assignee: sid.bugzilla → nobody
Component: General → Search
Product: Thunderbird → MailNews Core
QA Contact: general → search
Version: Trunk → unspecified
(fix up assignee)  sid, see comment 6
Assignee: nobody → sid.bugzilla
(In reply to comment #6)
> sid, is this perf related?

No, not really, unless we set the idle timeout to something really low.
(assuming this didn't land in v2.0.0.x)
I think we should close this and create a new bug for anything that's left
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Summary: Switch search indexing over to use nsIIdleService instead of message displayed timers → Switch Integrated Search indexing over to use nsIIdleService instead of message displayed timers
Target Milestone: --- → Thunderbird 3.0a3
You need to log in before you can comment on or make changes to this bug.