Closed
Bug 467118
Opened 13 years ago
Closed 7 years ago
Switch Integrated Search indexing over to use nsIIdleService instead of message displayed timers
Categories
(MailNews Core :: Search, defect)
MailNews Core
Search
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0a3
People
(Reporter: rain1, Assigned: rain1)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
6.43 KB,
patch
|
rain1
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•13 years ago
|
||
Other cleanup: - removed restartTimer() as we didn't need it at all except for one place - renamed onTimer to _continueSweep
|
|
Assignee | |
Updated•13 years ago
|
Attachment #350673 -
Flags: superreview?(beckley)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #350673 -
Flags: superreview?(beckley) → review?(beckley)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 350673 [details] [diff] [review] patch + other related cleanup v1 Looks fine
Attachment #350673 -
Flags: review?(beckley) → review+
|
||
Comment 3•13 years ago
|
||
Comment on attachment 350673 [details] [diff] [review] patch + other related cleanup v1 very cool, thx for doing this - but, if we're idle, I would think we could be much more aggressive about our timer, if I'm understanding the code correctly...
Attachment #350673 -
Flags: review?(bienvenu) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
David: yes, that should be possible. The throttling with this patch is the same as the throttling without, though. I'll leave this bug open, and I can revisit it once a couple of other patches in my queue get in.
Attachment #350673 -
Attachment is obsolete: true
Attachment #351702 -
Flags: superreview+
Attachment #351702 -
Flags: review+
|
|
Assignee | |
Updated•13 years ago
|
Attachment #351702 -
Flags: superreview+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 5•13 years ago
|
||
Comment on attachment 351702 [details] [diff] [review] patch (no changes, but to pre-empt any possible bitrot) [Checkin: Comment 5] http://hg.mozilla.org/comm-central/rev/db341efa61d3
Attachment #351702 -
Attachment description: patch (no changes, but to pre-empt any possible bitrot) → patch (no changes, but to pre-empt any possible bitrot)
[Checkin: Comment 5]
|
|
||
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 6•13 years ago
|
||
sid, is this perf related?
Assignee: sid.bugzilla → nobody
Component: General → Search
Product: Thunderbird → MailNews Core
QA Contact: general → search
Version: Trunk → unspecified
|
|
Assignee | |
Comment 8•12 years ago
|
||
(In reply to comment #6) > sid, is this perf related? No, not really, unless we set the idle timeout to something really low.
|
|
||
Comment 9•7 years ago
|
||
(assuming this didn't land in v2.0.0.x) I think we should close this and create a new bug for anything that's left
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Summary: Switch search indexing over to use nsIIdleService instead of message displayed timers → Switch Integrated Search indexing over to use nsIIdleService instead of message displayed timers
Target Milestone: --- → Thunderbird 3.0a3
You need to log in
before you can comment on or make changes to this bug.
Description
•