Firefox 3.1 Beta 2 identifies itself as "Mozilla Firefox" and overwrites an existing Firefox installation

VERIFIED FIXED in Firefox 3.1b2

Status

()

Firefox
Build Config
--
blocker
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: whimboo, Assigned: beltzner)

Tracking

({verified1.9.1})

Trunk
Firefox 3.1b2
verified1.9.1
Points:
---
Bug Flags:
blocking-firefox3.5 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2) Gecko/20081125 Firefox/3.1b2

When you install one of the build1 candidates of Firefox 3.1 Beta 2 on Windows (other platforms not tested yet) you will notice that it identifies as "Mozilla Firefox" instead of "Mozilla Firefox 3.1 Beta 2". As result an existing Firefox installation will be overwritten. This should be a blocker for Beta 2 and will cause a re-spin. Marking it as blocker for Beta 2. No idea which flag I have to set.
Component: Build Config → Build Config
Product: Core → Firefox
QA Contact: build-config → build.config
This is my fault. I forgot to file a bug similar to bug 458895.

Ben: we're going to need to respin for this.

Tony: I hope you'll agree with me that QA can continue with providing QA on the
existing builds, and then just move over to build 2 once we have them ready.
Aside from the simple string changes, nothing will be different.

Also: we should include this in the smoketests so we can catch it earlier.
Flags: blocking-firefox3.1+
(Reporter)

Updated

9 years ago
OS: Windows Vista → All
Hardware: PC → All
Created attachment 350528 [details] [diff] [review]
rebrand to Mozilla Firefox 3.1 Beta 2

The new Private Browsing stuff makes this a slightly more complicated patch. This should work, though. See attachment 342077 [details] [diff] [review] for a reference as to what we did in Beta 1.
Attachment #350528 - Flags: review?(gavin.sharp)
Comment on attachment 350528 [details] [diff] [review]
rebrand to Mozilla Firefox 3.1 Beta 2

This will result in:

<url> - Mozilla Firefox (Private Browsing) 3.1 Beta 2

when private browsing mode is enabled, but fixing that to keep the (Private Browsing) at the end is more trouble than it's worth, so beltzner and I agreed that this is sufficient.
Attachment #350528 - Flags: review?(gavin.sharp) → review+
Landed on the relbranch:
http://hg.mozilla.org/mozilla-central/rev/3ed5ca9b8277
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Assignee: nobody → beltzner

Comment 5

9 years ago
(In reply to comment #1)
> This is my fault. I forgot to file a bug similar to bug 458895.
> 
> Ben: we're going to need to respin for this.
> 
> Tony: I hope you'll agree with me that QA can continue with providing QA on the
> existing builds, and then just move over to build 2 once we have them ready.
> Aside from the simple string changes, nothing will be different.
> 
> Also: we should include this in the smoketests so we can catch it earlier.

My bad for missing this too.  We'll rerun the installation smoketests for each platform after the respins, and try to miminize any loss time.
(Reporter)

Comment 6

9 years ago
Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2 ID:20081201061100
Status: RESOLVED → VERIFIED
Target Milestone: --- → Firefox 3.1b2
(Reporter)

Comment 7

9 years ago
Sorry, I meant a Windows build and not an OS X one.
Keywords: fixed1.9.1
(Reporter)

Comment 8

9 years ago
Beta 2  looks fine.
Keywords: fixed1.9.1 → verified1.9.1
You need to log in before you can comment on or make changes to this bug.