467141 - "ASSERTION: failed to redistribute" with table-layout:fixed, width attributes

Status: VERIFIED FIXED

(Core :: Layout: Tables, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: failed to redistribute: 'unassignedSpace == 0', file /Users/jruderman/central/layout/tables/FixedTableLayoutStrategy.cpp, line 372

This assertion was added in bug 445142.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Hmmm.  So the problem is that I have an expression (a * b / c), and I want to ensure that if b==c, the result is *exactly* a, and if a==c, the result is *exactly* b.  I can get one of the two by parenthesizing the division, but I can't get both.  I guess we're losing here because the width is too large to be converted to float and back without losing precision.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Actually, we don't care about that invariant both ways; it's only one way.  So it's just a floating point issue.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fixed on mozilla-central: http://hg.mozilla.org/mozilla-central/rev/fb1b3f68b09d

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 350561 [details] [diff] [review]
patch

Simple fix for recent assertion regression which also fixes slight rounding errors in table width distribution for table-layout:fixed.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 350561 [details] [diff] [review]
patch

a191=beltzner

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fixed on 1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9cc347dd89b8