467156 - Fix calendar mode borders

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

This patch aligns the calendar mode borders to match task and mail view. It comes originally from attachment 350002 [details] in bug 462187 and has been reviewed there by berend. This patch does not contain the toolbar button and its styles from that bug.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Oops, missing qrefresh

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 350571 [details] [diff] [review]
Fix - v1

r=berend

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/7218f1a74382>

-> FIXED

Comment 4

[Andreas Treumann]

Attachment: missing borders in tasklist

Windows looks okay but Windows/MacOs looks odd (see screen shot)

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: How it looks for me on Linux

Windows/MacOS ? In one of both you probably mean Linux. Since Linux looks good for me, I assume this is a windows/macos issue. 

Daniel, could you take a look how to fix the MacOS issue? I'll see what I can do about windows.

I kind of wonder, I changed the calendar mode borders and now the task mode stuff is broken? Maybe it was due to my other "fix".

Comment 6

[Andreas Treumann]

Oh sorry, my mistake. I mean Linux/Macos looks odd. I checked your screen shot and it looks okay but on my SuSe 11 with KDE3.5 I can't see any border in the tasklist. Maybe a KDE/Mac only issue?

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I assume the problem is that my builds contained the patch in bug 456379 :-) Please verify that for the mentioned bug. Closing this bug since the calendar mode borders are as expected.

Comment 8

[Andreas Treumann]

I checked this again after bugfix 456379 is integrated -> VERIFIED.

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".