467251 - URL bar empty text should be right-aligned for RTL locales

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

The direction of URL bar is LTR even for RTL locales.  This causes the emptytext for URL bar (which should be translated and therefore RTL) appear on the left side of the URL bar, which is very odd.

This patch makes sure that this text appears right-aligned, as one would expect.

Comment 1

[Dão Gottwald [:dao]]

Comment on attachment 350659 [details] [diff] [review]
Patch (v1)

This belongs in browser/base/content/browser.css...

... but see also bug 416013, which I think is preferable.

Comment 2

[(no longer active)]

(In reply to comment #1)
> (From update of attachment 350659 [details] [diff] [review])
> This belongs in browser/base/content/browser.css...
> 
> ... but see also bug 416013, which I think is preferable.

Does that fix work even for cases where the direction of the text box is set to LTR using explicit CSS rules?  If I'm reading the patch there correctly, it checks the direction of the textbox, so it shouldn't work in this case.

If that bug doesn't fix this one, then I'll move my change to browser/base/content/browser.css...

Comment 3

[(no longer active)]

Attachment: Patch (v2)

Only change browser/base/content/browser.css.

Comment 4

[(no longer active)]

Dao: ping?

Comment 5

[Dão Gottwald [:dao]]

The patch in bug 416013 should fix this.

Comment 6

[Dão Gottwald [:dao]]

This should be fixed.

Ehsan, can you please verify?

Comment 7

[(no longer active)]

(In reply to comment #6)
> This should be fixed.
> 
> Ehsan, can you please verify?

Yep, it is indeed fixed.  Mozilla/5.0 (Windows; U; Windows NT 6.0; fa; rv:1.9.2a1pre) Gecko/20090114 Minefield/3.2a1pre

Comment 8

[Dão Gottwald [:dao]]

This bug is present on branch -- bug 416013 is waiting for approval.

Comment 9

[(no longer active)]

Fixed on the branch by bug 416013.