467283 - Don't take dirty rect into account when filtering is happening

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect, P2)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

See bug 463301. Attachment 347848 [details] [diff] needs to be updated and landed.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

This is already r+sr=dbaron

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 350949 [details] [diff] [review]
fix

Vlad, as dbaron suggested in bug 463301, I'm using a matrix-auto-save-restore object so you'd better review the API.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 350949 [details] [diff] [review]
fix

API looks fine, I might add a Restore() method to be able to explicitly restore the matrix before the destructor though (maybe null out mContext in that case and use that as a sentinel in the destructor).

But not a big deal, it can be added when there's a need.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Pushed 992000e45526 to trunk

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 350949 [details] [diff] [review]
fix

Simple and safe, we just paint more in some circumstances

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 350949 [details] [diff] [review]
fix

a191=beltzner

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/7f4cd6ac6636