467289 - Favicon for file://localhost/ isn't scaled down

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Stuart Morgan]

From the forums:
http://forums.mozillazine.org/viewtopic.php?f=12&t=972715
file://localhost/ uses the volume icon as the favicon, but it uses the 32x32 version without scaling it down.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Haha; I've had this screenshotted for years in my "weird UI I can't repro" folder.

hendy, will bug 463725 fix this (or only if the volume icon has a smaller size)?

Comment 2

[Christopher Henderson]

Attachment: Fix v1.0

hendy: turns out the provider will only resize the favicon if the load succeeds; since we can't load /localhost/, it never gets to that code
[3:52pm] sauron: yet we still get the icon? 
[3:53pm] hendy: yep, because it gets the icon from NSWorkspace regardless

Adds logic to allow for the possibility that a file didn't load, yet has an icon. That way, the resizing part of the code is run. The resized icon may look blurry, but that will be fixed as part of Bug 463725.

Comment 3

[Stuart Morgan]

Comment on attachment 350736 [details] [diff] [review]
Fix v1.0

r/sr=smorgan

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk.