Closed
Bug 467294
Opened 16 years ago
Closed 16 years ago
Images in bottom tabs are stretched
Categories
(Toolkit :: Themes, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: stefanh, Assigned: stefanh)
References
Details
(Keywords: fixed1.9.1, regression)
Attachments
(2 files, 1 obsolete file)
560 bytes,
application/vnd.mozilla.xul+xml
|
Details | |
2.02 KB,
patch
|
dao
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
SeaMonkey's Composer uses bottom tabs with list-style-images directly on the tab element. Those images are now stretched. See bug 378202 where this was originally fixed.
I think it's the combination of removing the "-moz-box-align: center;" for ".tab-bottom" and adding the below rule in tabbox.css that causes the images to be stretched:
89 tabbox.tabs-bottom > tabs > tab > .tab-middle,
90 tabs.tabs-bottom > tab > .tab-middle {
91 -moz-box-align: stretch;
This could probably be fixed on an app-specific level, but I'm filing this here since I think it should be possible to have icons in bottom tabs.
Assignee | ||
Updated•16 years ago
|
Keywords: regression
Assignee | ||
Comment 1•16 years ago
|
||
This should be the easiest and safest way to fix this (I don't want to mess up Markus stuff too much), I think. I've tested this in cz and it doesn't seem to change anything. It's also probably good to eliminate the risk of other things being vertically stretched.
Assignee | ||
Comment 2•16 years ago
|
||
Comment on attachment 350786 [details] [diff] [review]
One-liner, just use -moz-box-align: center
Dao said he could look at this.
Attachment #350786 -
Flags: review?(mano) → review?(dao)
Assignee | ||
Comment 3•16 years ago
|
||
Here's a testcase.
Comment 4•16 years ago
|
||
Doesn't this apply to normal tabs as well due to tab { -moz-box-align: stretch; }?
Assignee | ||
Comment 5•16 years ago
|
||
Comment on attachment 350786 [details] [diff] [review]
One-liner, just use -moz-box-align: center
(In reply to comment #4)
> Doesn't this apply to normal tabs as well due to tab { -moz-box-align: stretch;
> }?
True. Hmm, I guess I could use "center" on .tab-middle. Not sure if I dare to center everything inside the whole tab.
Attachment #350786 -
Flags: review?(dao)
Comment 6•16 years ago
|
||
-moz-box-align:stretch isn't needed in the first place, is it?
Assignee | ||
Comment 7•16 years ago
|
||
(In reply to comment #6)
> -moz-box-align:stretch isn't needed in the first place, is it?
You're right. And xul.css uses "-moz-box-align: center".
Assignee | ||
Comment 8•16 years ago
|
||
Hmm... .tabbrowser-tab in browser seems to have it too...
Assignee | ||
Comment 9•16 years ago
|
||
OK, this is much better. Since we have "-moz-box-align: center" and "-moz-box-pack: center" in xul.css, tabbrowser-tab doesn't need it, so I removed the style rules from browser.css. I also moved the .tab-middle rule (no reason to use tab > .tab-middle) down a bit, to keep it together with the other classes. I think for icons in bottom tabs to look really good, some extra polish might be necessary. I still haven't figured out how to do this without changing the look of the tabs, though, so I guess that'll have to wait.
Attachment #350786 -
Attachment is obsolete: true
Attachment #351416 -
Flags: review?(dao)
Updated•16 years ago
|
Attachment #351416 -
Flags: review?(dao) → review+
Assignee | ||
Comment 10•16 years ago
|
||
(In reply to comment #9)
> I still haven't figured out how to do this without
> changing the look of the tabs
This should of course be interpreted as "I still haven't figured out how to do this in a decent way without..." ;-)
Assignee | ||
Comment 11•16 years ago
|
||
Pushed c79c596ea42f to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Comment 12•16 years ago
|
||
Comment on attachment 351416 [details] [diff] [review]
New version
We should take this on branch, since it doesn't only affect bottom tabs.
Attachment #351416 -
Flags: approval1.9.1?
Updated•16 years ago
|
Attachment #351416 -
Flags: approval1.9.1? → approval1.9.1+
Comment 13•16 years ago
|
||
Comment on attachment 351416 [details] [diff] [review]
New version
a191=beltzner
Comment 14•16 years ago
|
||
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•