Closed Bug 467295 Opened 11 years ago Closed 11 years ago
Plugin timer is re-created everytime the page is scrolled
Something like this could be done to keep the current behavior. I have also a WIP patch to make all the plugins to use only 2 timers - one for normal and one for hidden plugins. But I guess with Compositor we could get rid of all the plugin timers.
Comment on attachment 350696 [details] [diff] [review] possible patch >diff --git a/layout/generic/nsObjectFrame.cpp b/layout/generic/nsObjectFrame.cpp >--- a/layout/generic/nsObjectFrame.cpp >+++ b/layout/generic/nsObjectFrame.cpp >@@ -482,16 +482,17 @@ private: > PRUint32 mLastEventloopNestingLevel; > PRPackedBool mContentFocused; > PRPackedBool mWidgetVisible; // used on Mac to store our widget's visible state > PRPackedBool mPluginPortChanged; > > // If true, destroy the widget on destruction. Used when plugin stop > // is being delayed to a safer point in time. > PRPackedBool mDestroyWidget; >+ PRPackedBool mTimerCancelled; Nit: mTimerCanceled. US spelling is shorter and (as pronunciation guide: stress moves to vowel before doubled consonant, but everyone pronounces "CANceled"). Who should review this? /be
I meant to write "US spelling is shorter and (...) in this case superior". Or "superiour", I won't argue that one ;-). /be
Comment on attachment 350696 [details] [diff] [review] possible patch r+ with brendan's nit addressed
Attachment #350696 - Flags: review?(joshmoz) → review+
(In reply to comment #2) > I meant to write "US spelling is shorter and (...) in this case superior". Or > "superiour", I won't argue that one ;-). I'm not sure why, but it's "superior" for us too.
Attachment #350696 - Flags: superreview?(roc) → superreview+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.