{inc}[MARGIN-C]Inconsistent layout with small margin-bottom (e.g. with <hr>)

RESOLVED WORKSFORME

Status

()

Core
Layout: Block and Inline
--
minor
RESOLVED WORKSFORME
10 years ago
9 years ago

People

(Reporter: Jesse Ruderman, Assigned: dholbert)

Tracking

(Blocks: 1 bug, {regression, testcase})

Trunk
regression, testcase
Points:
---
Dependency tree / graph
Bug Flags:
wanted1.9.1 +
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Reporter)

Description

10 years ago
The testcase and reference have the same final DOM, so they should look the same.

Based on layout/reftests/bugs/200774-1.html.  The original testcase had an <hr>, but I reduced it to a <div> with height and margin-bottom styles.
(Reporter)

Comment 1

10 years ago
Created attachment 350734 [details]
testcase (dynamic)
(Reporter)

Comment 2

10 years ago
Created attachment 350735 [details]
reference (static)
Bug appears on Linux, too.  (testcase has less space between "B" and "C" than reference case)

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20081129 Minefield/3.1b3pre ID:20081129020839
OS: Mac OS X → All
Hardware: PC → All
Component: Layout → Layout: Block and Inline
QA Contact: layout → layout.block-and-inline
Summary: Inconsistent layout with small margin-bottom (e.g. with <hr>) → {inc}[MARGIN-C]Inconsistent layout with small margin-bottom (e.g. with <hr>)
Yes, it is a regression WRT Firefox 2.
Firefox 3.0.4 shows the bug.
Firefox 2.0.0.18 doesn't show the bug.
Keywords: regression, regressionwindow-wanted
Flags: wanted1.9.1? → wanted1.9.1+
works:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007120205 Minefield/3.0b2pre ID:2007120205
fails:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007120305 Minefield/3.0b2pre ID:2007120305

=> range:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-12-02+02%3A00&maxdate=2007-12-03+04%3A00&cvsroot=%2Fcvsroot
Keywords: regressionwindow-wanted
Blocks: 403426
(Reporter)

Comment 7

9 years ago
Created attachment 374670 [details]
testcase 2 (dynamic)

I think this is clearer than the first testcase-reference pair.
(Reporter)

Comment 8

9 years ago
Created attachment 374671 [details]
reference 2 (static)
(Reporter)

Comment 9

9 years ago
dholbert, it would be great if you could fix this like you did for bug 405517, bug 418766, and bug 421239.  This is the kind of thing that refdyn tends to hit over and over again.
Cool, I'll take a look. (This could be a regression from bug 405517, too.)
Yup, regression from bug 405517 -- confirmed by taking a checkout from just before that patch landed and then applying the patch manually. :-/
Blocks: 405517
No longer blocks: 403426
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
FWIW, I tried reverting bug 405517's patch and applying the older patch from that bug in its place, per my comment at the end of bug 405517 comment 11.  (using an up-to-date mozilla-central build)

However, that change breaks 2 reftests: text/444656.html and margin-collapsing/block-abs-pos-1.html
(Reporter)

Comment 13

9 years ago
WFM

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091008 Firefox/3.7a1pre
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → WORKSFORME
(Reporter)

Comment 14

9 years ago
reftest:
http://hg.mozilla.org/mozilla-central/rev/c8a743c6f944
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.