Closed Bug 467348 Opened 13 years ago Closed 13 years ago

ReleaseTaggingFactory should not try to do 'hg up -r' for respins (because the following step is 'hg up -C -r')

Categories

(Release Engineering :: General, defect, P2)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

References

Details

(Whiteboard: [hg-automation])

Attachments

(1 file)

Hit this during 3.1b2build2 -- it looks like this BuildStep should be part of the 'if build == 1' level rather than run regardless.
Whiteboard: [hg-automation]
I'm not sure whether this is relevant, but nthomas and I talked about a similar issue a while ago on IRC: http://people.mozilla.org/~gavin/logs/build.20081028.log
(In reply to comment #1)
> I'm not sure whether this is relevant, but nthomas and I talked about a similar
> issue a while ago on IRC:
> http://people.mozilla.org/~gavin/logs/build.20081028.log

Yeah, it looks like you guys caught this silliness before I did.
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
Attachment #351185 - Flags: review?(nthomas)
Priority: -- → P2
Attachment #351185 - Flags: review?(nthomas) → review+
Comment on attachment 351185 [details] [diff] [review]
fix tagging respin logic

Looks ok to me.

BTW, random trivia:
 relbranchName = 'GECKO%s_%s_RELBRANCH' % (
   milestone.replace('.', ''), datetime.now().strftime('%Y%m%d'))
means we use local time for hg releases, while Bootstrap uses UTC.
Comment on attachment 351185 [details] [diff] [review]
fix tagging respin logic

Checking in process/factory.py;
/cvsroot/mozilla/tools/buildbotcustom/process/factory.py,v  <--  factory.py
new revision: 1.49; previous revision: 1.48
done
Attachment #351185 - Flags: checked‑in+
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.