467348 - ReleaseTaggingFactory should not try to do 'hg up -r' for respins (because the following step is 'hg up -C -r')

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

Hit this during 3.1b2build2 -- it looks like this BuildStep should be part of the 'if build == 1' level rather than run regardless.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

I'm not sure whether this is relevant, but nthomas and I talked about a similar issue a while ago on IRC: http://people.mozilla.org/~gavin/logs/build.20081028.log

Comment 2

[[e-mail] (:bhearsum)]

(In reply to comment #1)
> I'm not sure whether this is relevant, but nthomas and I talked about a similar
> issue a while ago on IRC:
> http://people.mozilla.org/~gavin/logs/build.20081028.log

Yeah, it looks like you guys caught this silliness before I did.

Comment 3

[[e-mail] (:bhearsum)]

Attachment: fix tagging respin logic

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 351185 [details] [diff] [review]
fix tagging respin logic

Looks ok to me.

BTW, random trivia:
 relbranchName = 'GECKO%s_%s_RELBRANCH' % (
   milestone.replace('.', ''), datetime.now().strftime('%Y%m%d'))
means we use local time for hg releases, while Bootstrap uses UTC.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 351185 [details] [diff] [review]
fix tagging respin logic

Checking in process/factory.py;
/cvsroot/mozilla/tools/buildbotcustom/process/factory.py,v  <--  factory.py
new revision: 1.49; previous revision: 1.48
done