467368 - _wfullpath implementation doesn't handle paths with "../" correctly

Status: RESOLVED FIXED

(Core :: General, defect)

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: from patch queue

this if from our patch queue, so 3 lines of context.  Let me know if you need a proper patch to review

Comment 2

[Doug Turner (:dougt)]

spacing is off (both extra ws added, and the indentation is wrong)

can you test _wgetcwd for error?  Otherwise, i think this might do the wrong thing:

unsigned long len = wcslen(cwd); 


test for error:  CeGetCanonicalPathName

Comment 3

[John Wolfe (:wolfe)]

Attachment: v2.0 patch

Almost identical patch - just added fixed formatting, added safety checks into function calls to _wgetcwd() and CeGetCanonicalPathName() - as per doug's comment

Comment 4

[Doug Turner (:dougt)]

changeset:   22818:10a2365bd525
tag:         tip
user:        John Wolfe <[e-mail]
date:        Mon Dec 15 10:53:21 2008 -0800
summary:     Bug 467368 - Windows Mobile  _wfullpath implementation doesn't handle paths with ../ correctly

I added a #error in the !30 section so that people do not chase down this bug on older SDKs.  However, I do not think it matters since the shunt will not be of much real value on those SDKs as so much required stuff is missing in order to build mozilla.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Doug or John, please land this on 1.9.1

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ef7b9729d6a4