467370 - Missing or invalid local file urls don't use error page site icon

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: Location Bar & Autocomplete, defect)

Description

[Chris Lawson (gone)]

STR: Go to file:///path/to/nonexistent/foo .

AR: Observe "untitled" page icon, like that shown for about:blank.

ER: Observe error page site icon (like that shown for http://non.existent.foo/ ).

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This might fix bug 398924, too.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We specifically register about:local_file for missing local files (and some other purposes related to history), and register the document icon as its icon.

http://mxr.mozilla.org/camino/source/camino/src/browser/SiteIconProvider.mm#588

I'm not sure what happens if we can't get the icon from the file for some reason (I think we'd fall back to the document icon, but I'm not sure).  Either way, we're always going to early return from fetchFavoriteIconForPage:withIconLocation:allowNetwork:notifyingClient: and thus never notify the BrowserWrapper code in imageLoadedNotification: (or otherwise end up in updateSiteIconImage: where we set the error page site icon).

I'm not sure we can fix this without major surgery somewhere, and I certainly don't want to be the one doing it ;)