Closed Bug 46757 Opened 24 years ago Closed 24 years ago

Remove menubar grippy for beta2 (make it non-collapsible)

Categories

(Core :: XUL, defect, P3)

Product:
Core
Component:
XUL
Type:
defect

Tracking

()

Status:
VERIFIED WONTFIX

People

(Reporter: jrgmorrison, Assigned: bugs)

References

Details

(Whiteboard: [nsbeta2-][nsbeta3-] ETA 8/01 - Still on Linux only 08/02 build)

There are a variety of bugs concerning <toolbox>, <menubar> and <toolbar> which will be addressed with fixes in nsbeta3 (e.g. bug 43774). However, the fact is that collapsing the grippy on a menubar crashes everytime in the classic skin for PR2 candidate builds. This crashes to browser, mailnews, AIM, addressbook, etc. The simple fix for PR2 is to hide the toolbargrippy so it can't be collapsed in the first place (which matches the functionality of the <menubar> in the modern skin). Something like (in global.css): /* XXX for PR2, hide the toolbargrippy on the menubar to avoid a crash when it is clicked */ menubar > toolbargrippy { visibility: collapse; } Nominating for nsbeta2. This is a 100% crash on _all_ platforms in many places in the UI when using the classic skin. It will crash on the first click everytime (today's and previous builds).
Keywords: crash, nsbeta2
To be clear, when I say menubar, I am referring to the element that contains "File, Edit, View, Search ..." at the top of every window (on linux/win32). [... and this does not affect Mac; not sure why I said _all_ above.]
nsbeta2+ to fix crash by disabling collapsable menubar
Whiteboard: [nsbeta2+]
not a problem in the modern skin, tho'? if so, methinks this belongs in Skinability not xp apps: gui. (methinks the cause of this might be too lowlevel for Themes component, but...)
Component: XP Apps: GUI Features → Skinability
QA Contact: sairuh → paw
I don't understand why this isn't an exact dup of bug 43774 (which says that you crash when trying to minimize the menubar in the classic skin).
Component: Skinability → XP Toolkit/Widgets
*** Bug 43774 has been marked as a duplicate of this bug. ***
*** Bug 23140 has been marked as a duplicate of this bug. ***
Ben, I have a fix for this.
Assignee: ben → bryner
Status: NEW → ASSIGNED
Well, the bad news here is that in testing my fix, I found that after collapsing the menubar, it completely went away - there was no way to get it back. I'll go ahead and check in the crasher fix anyway.
bryner, that's not your fix's fault: bug 44756
I think we should remove the menubar grippy in the beta2 branch, because of the disappearing problem.
I would tend to agree with you.
Checked in fix.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
(Note: checked in fix on trunk, will check in on branch when the branch opens)
Checked in on the branch, too.
Are you going to remove the toolbargrippy for menubar's (on the M17 branch only). That was the point of this bug -- real fixes can come later, but let's not ship with broken UI that can be resolved easily with a simple style rule change. reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Hm... I'm going to reassign to Ben for that, and change the summary.
Assignee: bryner → ben
Status: REOPENED → NEW
Summary: crasher in PR2; collapse the menubar in the classic skin → Menubar disappears after being collapsed in classic skin
This is just to remove the grippy for beta2; the disappearing issue is bug 44756, and is nsbeta3+
Summary: Menubar disappears after being collapsed in classic skin → Remove menubar grippy for beta2
bah. humbug.
Status: NEW → ASSIGNED
Summary: Remove menubar grippy for beta2 → Menubar disappears after being collapsed in classic skin
Summary: Menubar disappears after being collapsed in classic skin → Remove menubar grippy for beta2 (make it non-collapsible)
Removing crash keyword because the crash is fixed and the summary has changed.
Keywords: crash
ben...we need ASAP on branch please!
Whiteboard: [nsbeta2+] → [nsbeta2+] ETA 8/01
done!
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
This fixed in the Windows and Mac builds 2000080204 m17. NOT FIXED on Linux build 2000080204 m17 Reopening
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
It's only on the classic skin running under Linux. The modern skin is ok.
Whiteboard: [nsbeta2+] ETA 8/01 → [nsbeta2+] ETA 8/01 - Still on Linux only 08/02 build
Moving on to [nsbeta2-]. Need to relnote2 for PR2 that restart fixes Linux/classic problem.
Keywords: relnote2
Whiteboard: [nsbeta2+] ETA 8/01 - Still on Linux only 08/02 build → [nsbeta2-] ETA 8/01 - Still on Linux only 08/02 build
nav triage team: nsbeta3- since the root cause is being fixed. QA is welcome to mark invalide when they feel like it.
Whiteboard: [nsbeta2-] ETA 8/01 - Still on Linux only 08/02 build → [nsbeta2-][nsbeta3-] ETA 8/01 - Still on Linux only 08/02 build
Marking WONTFIX (paw -- is this in the release notes, or do we need to make this note).
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → WONTFIX
Adding keyword to bugs with nsbeta3 triage value in status whiteboard so tracking queries will not be misled
Keywords: nsbeta3
vrfy wontfix (old bug, was fixed and relnoted for beta2 as appropriate)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.