467570 - Cannot hide search bar in bookmark manager

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[asmpgmr]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081201 SeaMonkey/2.0a2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081201 SeaMonkey/2.0a2pre

Unchecking View -> Search bar in the bookmark manager menu should hide the search bar but it does not even though the check mark does toggle. This appears to be regression from bug 460756.

Reproducible: Always

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Confirming, the toggle does nothing.

The question is how to solve this though. Since it's not a toolbar anymore the solution might be to simple remove the menu entry.

Comment 2

[asmpgmr]

Since the search box is part of the toolbar and you can toggle off the toolbar this seems like a reasonable solution.

Comment 3

[Philip Chee]

If we restore the search-box back to it's own toolbar then this toggle will work again.

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #3)
> If we restore the search-box back to it's own toolbar then this toggle will
> work again.

Bug 460756 was exactly about removing the extra toolbar. Are you suggesting it will/should come back? Then what's the bug for that? Otherwise I think the consideration here should only be whether to change the menu item so that it toggles the visibility of the search box (and its label of course) or to remove it like asmpgmr and I seem to agree upon.

Comment 5

[[e-mail]]

Who knows, we might even end up making this toolbar customisable and then the search box can be hidden again for those who don't want it.

Comment 6

[Stefan [:stefanh]]

Attachment: Remove menuitem, hide search box in search results window

Sorry, for the confusion - this is my fault... I think this should do it.

Comment 7

[Stefan [:stefanh]]

Comment on attachment 351201 [details] [diff] [review]
Remove menuitem, hide search box in search results window

Oops, forgot to request review...

Comment 8

[[e-mail]]

Comment on attachment 351201 [details] [diff] [review]
Remove menuitem, hide search box in search results window

>+    document.getElementById("bookmarks-search-box").setAttribute("hidden","true")
Might as well modernise this to .hidden = true;

Comment 9

[Stefan [:stefanh]]

Pushed 7417a1b5decd to comm-central (with ".hidden = true;").