ABC bytecode verifier spec

RESOLVED WORKSFORME

Status

Tamarin
Verifier
P5
normal
RESOLVED WORKSFORME
9 years ago
6 years ago

People

(Reporter: Jeff Dyer, Assigned: Andre Kruetzfeldt)

Tracking

(Blocks: 1 bug)

unspecified
Q1 12 - Brannan
x86
Windows 7
Dependency tree / graph
Bug Flags:
in-testsuite -
flashplayer-injection -
flashplayer-qrb +
flashplayer-bug -

Details

Attachments

(1 attachment)

79.69 KB, patch
Edwin Smith
: review+
Details | Diff | Splinter Review
(Reporter)

Description

9 years ago
We need an accurate specification of what the ABC bytecode verifier is doing. This would ideally include hints for compilerwriters on working around verifier errors.
(Reporter)

Comment 1

9 years ago
Created attachment 351226 [details] [diff] [review]
patch
Attachment #351226 - Flags: review?(edwsmith)
(Reporter)

Comment 2

9 years ago
This patch adds the wiki source text and the generated html file of the verifier spec. Also added is a python script that does the translation.

Jd

Updated

9 years ago
Attachment #351226 - Flags: review?(edwsmith) → review+

Updated

8 years ago
Priority: -- → P5
Target Milestone: --- → flash10.1

Updated

8 years ago
Target Milestone: flash10.1 → flash10.2

Updated

8 years ago
Assignee: jodyer → nobody
Status: ASSIGNED → NEW
Component: Virtual Machine → Verifier
QA Contact: vm → verifier

Updated

7 years ago
Assignee: nobody → akruetzf
Depends on: 641055
Flags: in-testsuite-
Flags: flashplayer-qrb+
Flags: flashplayer-injection-
Flags: flashplayer-bug-
OS: Mac OS X → Windows 7
(Assignee)

Comment 3

7 years ago
Updating the current feedback on spec and bytecode notes.
(Assignee)

Updated

7 years ago
Target Milestone: Q3 11 - Serrano → Q1 12 - Brannan

Comment 4

6 years ago
What's the plan for this document and updates?

Comment 5

6 years ago
I don't beleive there is a plan, other than to make this content into a chapter in the overall avm/abc spec, which will live and be updated in tamarin-redux.  A separate document should not be necessary.
(Assignee)

Comment 6

6 years ago
Ed, please confirm that I can land the patch in your doc repo or tip if it is ready.

Updated

6 years ago
Depends on: 416391

Comment 7

6 years ago
(In reply to Andre Kruetzfeldt from comment #6)
> Ed, please confirm that I can land the patch in your doc repo or tip if it
> is ready.

After some digging, I found the master bug: Bug 416391. (this bug is for
a chapter on the verifier, not the overall spec).  Here's what needs to happen:

1. review legalese
2. rebase that repo to tamarin-redux, generate a single patch
3. post it on bug 416391, I'll review and maybe get more eyes on it.
4. then we land.
5. nice to have (new bug?): generate docs during the build and post them to 
   a well known URL.

Sound good?
(Assignee)

Comment 8

6 years ago
Yup, I'll take a shot at it.
(Assignee)

Comment 9

6 years ago
The patch in this bug can land "as is" it does not alter the doxygen material.

Comment 10

6 years ago
It appears to have landed a long time ago. closing.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WORKSFORME

Updated

6 years ago
No longer depends on: 416391

Updated

6 years ago
Blocks: 693588
You need to log in before you can comment on or make changes to this bug.