467638 - run-mozilla.sh should not md5sum core files

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Right now run-mozilla.sh runs md5sum on any core file when starting up.  This makes Mozilla quite slow to start for any user whose home directory has a large core file.

Given that core files on Linux are now generally called core.$PID, we should probably just remove the "Oh no, we dumped core, do you want to debug it?" code.  This code doesn't make sense for most users; only for developers, and even then it's probably not all that helpful anymore given that it doesn't work with current Linux core file naming and nobody's complained.

However, if we ever add it back, it should use something quick, like stat, rather than md5sum.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fixed on mozilla-central: http://hg.mozilla.org/mozilla-central/rev/9a55fd36efa2

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 351050 [details] [diff] [review]
patch

This is low-risk and I think worth taking on the branch; it helps users who have large core files in their home directory.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 351050 [details] [diff] [review]
patch

a191=beltzner

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/8490dbe99b99