467648 - nsHTMLDNSPrefetch leak

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Jesse Ruderman]

Attachment: trace-refcnt log

I got a few logs of Firefox leaking nsHTMLDNSPrefetch objects.  nsDNSService was not leaked, so I'm guessing this isn't bug 102229.

Comment 1

[Patrick McManus [:mcmanus]]

I suspect this is a dup of bug 463724 involving a particularly recalcitrant nameserver.

Comment 2

[Jesse Ruderman]

Attachment: new trace-refcnt log showing leaked nsHTMLDNSPrefetch::nsDeferrals

Since the landing of bug 464838, I've been seeing this occasionally.  Same root cause as this bug?

Comment 3

[Patrick McManus [:mcmanus]]

this is slightly new. It is also a shutdown behavior, so it doesn't present a stability danger to testing, but it can be easily fixed. I'll make a patch.

Comment 4

[Patrick McManus [:mcmanus]]

Attachment: fix leaked references in nsDeferrals Queue on Shutdown

in retrospect I think this report is really a dup, with nsdeferrals taking the ref nshtmldnspretch held pre landing of 464838

However nsdeferrals hsa a fifo of references that will get abandoned on shutdown if the queue is not empty. This patch fixes that.

I don't think the dns patch is responsible for the giant leaks in baseurlparser, standardurl, or the big jump in stringbuffer.

let me know if there is reason to disagree.

Comment 5

[Boris Zbarsky [:bzbarsky]]

baseurlparser, standardurl, and stringbuffer are all things that would be held by those nsIURIs.

Comment 6

[Patrick McManus [:mcmanus]]

Comment on attachment 352211 [details] [diff] [review]
fix leaked references in nsDeferrals Queue on Shutdown

ok - there are 511 of the first two, (and twice as many stringbuffers - two per nsIURI I suppose?) which would indicate orphaning a full queue. So that patch should do it.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 352211 [details] [diff] [review]
fix leaked references in nsDeferrals Queue on Shutdown

Looks good.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/ace5e9bbb02c

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Looks like this was landed on the 1.9.1 branch as part of bug 464838's rollup patch, right? Marking fixed1.9.1, but would appreciate confirmation!

Comment 10

[Boris Zbarsky [:bzbarsky]]

Yeah, I believe so.

Comment 11

[Patrick McManus [:mcmanus]]

yes this is on 1.9.1