467751 - Debian System Plugin Location - XRE Part

Status: NEW

(Toolkit :: Startup and Profile System, defect)

Description

[Alexander Sack]

(Most likely wrong component ... file affected is in toolkit/xre/; why doesnt toolkit have a "General" component?)

Bug 440506 landed support for a legacy plugin location /usr/lib/mozilla/plugins.

I don't agree that /usr/lib/mozilla is really a good location for that, however the patch committed forgot the toolkit/xre/ part.

Comment 1

[Alexander Sack]

Attachment: for 1.9.1

from ubuntu xulrunner-1.9.1 packaging branch

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 351167 [details] [diff] [review]
for 1.9.1

I think Benjamin is the best reviewer for this.

Comment 3

[Mike Hommey [:glandium]]

I don't see what kind of need the toolkit/xre part fulfils.

Comment 4

[Benjamin Smedberg]

Comment on attachment 351167 [details] [diff] [review]
for 1.9.1

I think mh is correct here: the default plugins provider already provides this key: http://mxr.mozilla.org/mozilla-central/source/xpcom/io/nsAppFileLocationProvider.cpp#596

This result is then *aggregated* with the nsXREDirProvider version, see here: http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/nsXREDirProvider.cpp#777

There should be no need for this patch. I would love to have a unit-test for it, though!

Comment 5

[Mike Hommey [:glandium]]

(In reply to comment #4)
> I would love to have a unit-test for it, though!

AFAIK, this is not possible, as it would rely on files being installed in a system directory, which the build/check scripts usually won't have access to.
The only way I see to circumvent this would be to use something like fakechroot, but this may be overkill.

Comment 6

[Benjamin Smedberg]

Oh, I didn't mean anything that complicated. I just meant to ask the directory service to make sure that NS_SYSTEM_PLUGINS_DIR was included in NS_APP_PLUGINS_DIR_LIST (if NS_SYSTEM_PLUGINS_DIR is present at all).

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:mossop, could you have a look please?
For more information, please visit auto_nag documentation.