467756 - Thunderbird versions on beta1 branch do not accept Lightning anymore

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Berend Cornelius]

On the final thunderbird 3 beta1 release branch, that has recently been opened Lightning is not accepted as extension anymore.

Comment 1

[Berend Cornelius]

Attachment: patch v. #1

Andreas and me tested this version, that simply modifies the min-version entry in calendar/lightning/install.rdf by introducing a litaral value. Maybe we find a more elegant and basic way to define the min version but for the moment this should work.

Comment 2

[Berend Cornelius]

Attachment: patch v. #2

As Mark Banner (Standard8a)objected on irc, it will be better to set the min-version to 3.0b1 instead of 3.0b1* which would include the 3.b1pre. 3.b1pre again may be incompatible in its early versions with the current lightning build.
Consequently probably also the file
http://mxr.mozilla.org/comm-central/source/calendar/lightning/install.rdf#14

should contain the same version id. Philipp what do you think?

Comment 3

[Berend Cornelius]

We should also keep in mind that the current min-version entry should be overworked as soon as Thunderbird Beta1 is released and we run in danger to become incompatible with that build.

Comment 4

[Philipp Kewisch [:Fallen][☁️📆]]

Yes, I agree. Please put that into the patch.

Comment 5

[Berend Cornelius]

Attachment: patch v. #2

new patch that also modifies the install.rdf file of the Google-provider

Comment 6

[ause]

Comment on attachment 351362 [details] [diff] [review]
patch v. #2

it's a hack but the best we can do atm.

Comment 7

[Berend Cornelius]

pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/6a04731e43d5

->fixed

Comment 8

[Philipp Kewisch [:Fallen][☁️📆]]

Berend, where does GData's install rdf define THUNDERBIRD_VERSION ? This needs to be done explicitly afaik.

Comment 9

[Andreas Treumann]

Checked in latest lightning and gdata builds, looks fine. Philipps concerns are arbitrary.