Closed Bug 467756 Opened 11 years ago Closed 11 years ago

Thunderbird versions on beta1 branch do not accept Lightning anymore

Categories

(Calendar :: Calendar Views, defect, critical)

defect
Not set
critical

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: berend.cornelius09, Assigned: berend.cornelius09)

Details

Attachments

(1 file, 2 obsolete files)

On the final thunderbird 3 beta1 release branch, that has recently been opened Lightning is not accepted as extension anymore.
Attached patch patch v. #1 (obsolete) — Splinter Review
Andreas and me tested this version, that simply modifies the min-version entry in calendar/lightning/install.rdf by introducing a litaral value. Maybe we find a more elegant and basic way to define the min version but for the moment this should work.
Assignee: nobody → Berend.Cornelius
Status: NEW → ASSIGNED
Attachment #351169 - Flags: review?
Attached patch patch v. #2 (obsolete) — Splinter Review
As Mark Banner (Standard8a)objected on irc, it will be better to set the min-version to 3.0b1 instead of 3.0b1* which would include the 3.b1pre. 3.b1pre again may be incompatible in its early versions with the current lightning build.
Consequently probably also the file
http://mxr.mozilla.org/comm-central/source/calendar/lightning/install.rdf#14

should contain the same version id. Philipp what do you think?
Attachment #351169 - Attachment is obsolete: true
Attachment #351175 - Flags: review?(ause)
Attachment #351169 - Flags: review?
We should also keep in mind that the current min-version entry should be overworked as soon as Thunderbird Beta1 is released and we run in danger to become incompatible with that build.
Yes, I agree. Please put that into the patch.
Attached patch patch v. #2Splinter Review
new patch that also modifies the install.rdf file of the Google-provider
Attachment #351175 - Attachment is obsolete: true
Attachment #351362 - Flags: review?(ause)
Attachment #351175 - Flags: review?(ause)
Attachment #351362 - Flags: review?(ause) → review+
Comment on attachment 351362 [details] [diff] [review]
patch v. #2

it's a hack but the best we can do atm.
pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/6a04731e43d5

->fixed
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Berend, where does GData's install rdf define THUNDERBIRD_VERSION ? This needs to be done explicitly afaik.
Target Milestone: 1.0 → ---
Target Milestone: --- → 1.0
Checked in latest lightning and gdata builds, looks fine. Philipps concerns are arbitrary.
Status: RESOLVED → VERIFIED
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.