46779 - clean up nsIServiceManager

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Warren Harris]

- nsIServiceManager
    - Can't change because of JRE 1.3
    - Ray to consider nsIServiceManager2 for methods that include a
  version parameter
    - Remove nsServiceManager to a separate.
    - nsIShutdownListener should move to a separate file or die (dp).
    - InitXPCOM and ShutdownXPCOM need fixed ordinals, probably in a new
  file.
    - NS_NewServiceManager should be removed.
    - ray to own.

Comment 1

[Ray Whitmer]

I decided we do not need a version parameter.  It was really just an 
optimization that I am now confident can be done in other ways.

Comment 2

[Ray Whitmer]

Let me list issues with this API and look for clarification.

First, I found a note that we cannot change the API.  That seems to contradict 
much of an API cleanup whatsoever.  Things that may be doable anyway:

1.  Is there a reason this interface is not declared in an idl file?
2.  We need to move nsIShutdownListener to a new file.  Shutdown listeners are 
only used in one place (deallocating string case conversion tables) in the code 
that I can find, that could probably be solved via a virtual destructor.  But it 
seems like a good function to have when trying to replace static destructors 
with something which shuts down when the service it depends upon shuts down.  Do 
we need to keep it?
3.  Remove NS_NewServiceManager.
4.  Make fixed ordinals for a number of XPCOM static calls including InitXPCOM, 
a method to get the global service manager, etc.

Comment 3

[Ray Whitmer]

Additional things that I would do if I could change the API:

1.  We have two versions of ReleaseService, which appear to be obsolete.
2.  Eliminate the overloading so we could use IDL.
3.  Try and understand the purpose, if any, for RegisterService.

Comment 4

[Warren Harris]

The idea behind RegisterService was that if you had an existing object (not one 
implicitly create through the act of getting a service), you could register that 
object as a service. Yeah, it's not strictly necessary since you could always 
invent a dummy factory to do the same thing.

In general I agree with your proposed changes, but the issue was that the OJI 
plugin might be using the existing service manager interface. Cc'ing Stanley for 
his input on this.

Stanley: I'm guessing that you're probably only calling GetService without the 
shutdown listener, right? Ray: Maybe you can rework things here while keeping 
GetService alive for OJI.

Comment 5

[Warren Harris]

Oops, really cc'ing Stanley this time.

Comment 6

[Phil Peterson]

Not holding PR3 for this; marking nsbeta3-.

Comment 7

[Warren Harris]

Assigning rest of xpcom stuff to myself (from Ray).

Comment 8

[Asa Dotzler [:asa]]

reasigning warren bugs to default component owners.

Comment 9

[Doug Turner (:dougt)]

reassign all kandrot xpcom bug.

Comment 10

[Doug Turner (:dougt)]

this interface should be idl'ified.

Comment 11

[Doug Turner (:dougt)]

These changes have been made and checked in this evening.