467816 - Composer's Show/Hide Status bar menuitem behaves strange

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[Stefan [:stefanh]]

I see this in 20081128 and todays nightly:

1) Launch SeaMonkey
2) Open Composer
3) Ensure that the Status Bar is visible
4) View --> Show/Hide: Status Bar
5) Note that there are 2 checkmarks in the menuitem

ajschult seem to get no checkmark at all (at least he didn't when I asked him yesterday).

Comment 1

[Robert Kaiser]

I also see no checkmark on Linux with my custom theme, even though the other items have it (so probably no theme issue), and the "same" item in the browser window works fine.

Comment 2

[Stefan [:stefanh]]

That menuitem is overlayed from utilityOverlay.xul, I think.

Comment 3

[Stefan [:stefanh]]

(In reply to comment #2)
> That menuitem is overlayed from utilityOverlay.xul, I think.

erm, composers Show/hide statusbar menuitem of course.

Comment 4

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a5pre) Gecko/20070515 SeaMonkey/1.5a] (nightly) (W2Ksp4)

Works fine.

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081104 SeaMonkey/2.0a2pre] (nightly) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b3pre) Gecko/20081216 SeaMonkey/2.0a3pre] (nightly) (W2Ksp4)

No checkmark.

Comment 5

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.2pre) Gecko/2008072102 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

Already no checkmark.

Comment 6

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a5pre) Gecko/2007052914 SeaMonkey/2.0a1pre] (2007-05-29-14-trunk) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2008020102 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008042502 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008060802 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008061302 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008061502 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008061601 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

Work fine.

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008061702 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008061802 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.1pre) Gecko/2008062902 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

No checkmark.


Regression timeframe:
http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2008-06-16+00&enddate=2008-06-17+03
(nothing obvious)
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=MozillaTinderboxAll&branch=HEAD&branchtype=match&sortby=Date&hours=2&date=explicit&mindate=2008-06-16+00&maxdate=2008-06-17+03&cvsroot=%2Fcvsroot
Obvious culprit would be bug 279144.

Comment 7

[[e-mail]]

Oops, I forgot to make it a checkbox menuitem :-(

I wonder whether we should fix it in utilityOverlay and remove the subsequently unnecessary attribute from all the other consumers?

Comment 8

[[e-mail]]

Attachment: Proposed patch

Comment 9

[[e-mail]]

Pushed changeset 745bcd3b55b3 to comm-central.