467951 - Build NSPR on NetBSD with pthreads by default

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Kaspar]

Attachment: Proposed patch - build NSPR with pthreads on NetBSD

When working on bug 466180, I observed rather mysterious segfaults with NSS when it was built/running on NetBSD 5.0_BETA (it doesn't on NetBSD 4.0).

Apparently, changes in the NetBSD 5.0 threading code make it no longer possible to reliably compile a "Classic NSPR" version on this platform. I therefore suggest to enable pthreads by default (as is already the case for OpenBSD and FreeBSD).

Note that the NetBSD package (http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/devel/nspr/) already does this by supplying the --with-pthreads configure argument.

Comment 1

[Wan-Teh Chang]

Comment on attachment 351414 [details] [diff] [review]
Proposed patch - build NSPR with pthreads on NetBSD

r=wtc.  Great idea.  It's always good to use pthreads if the
pthread library is available.

(When attaching a patch that changes configure.in, it is
customary to omit the changes to configure to reduce the
noise in the patch.)

The NetBSD package's patches directory has 13 patches.
Would be nice to get them merged into the upstream at some
point.

Comment 2

[Martin Husemann]

Just a side note: thirteen is an underestimate - it uses a few more from other directories. I would be glad to work with anyone trying to integrate some of the changes. Sometimes it seems a bit hard, my personal favorites are: #244010 (I have updated code for firefox3, should update that bug) and #333347.

Comment 3

[Wan-Teh Chang]

I checked in the patch on the NSPR trunk (NSPR 4.7.4).