467971 - random failures on test_multiple_visits_around_sync.js

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Robert Strong (they/them - no direct email)]

From log
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1228424276.1228427465.8135.gz&fulltext=1

<a name='err0'></a><a href='#err1'>NEXT ERROR</a> <font color='000080'>TEST-UNEXPECTED-FAIL | ../../../../_tests/xpcshell-simple/test_places/sync/test_multiple_visits_around_sync.js | test failed, see log
</font>../../../../_tests/xpcshell-simple/test_places/sync/test_multiple_visits_around_sync.js.log:
>>>>>>>
*** test pending
*** test pending
*** test finished
*** running event loop
*** exiting
<a name='err1'></a><a href='#err2'>NEXT ERROR</a> <font color='000080'>*** TEST-UNEXPECTED-FAIL | ../../../../_tests/xpcshell-simple/test_places/sync/head_sync.js | false == true
</font>JS frame :: e:/slave/trunk_win2k3-8/build/tools/test-harness/xpcshell-simple/head.js :: do_throw :: line 101
JS frame :: e:/slave/trunk_win2k3-8/build/tools/test-harness/xpcshell-simple/head.js :: do_check_eq :: line 120
JS frame :: e:/slave/trunk_win2k3-8/build/tools/test-harness/xpcshell-simple/head.js :: do_check_true :: line 126
JS frame :: ../../../../_tests/xpcshell-simple/test_places/sync/head_sync.js :: new_test_visit_uri_event :: line 236
JS frame :: ../../../../_tests/xpcshell-simple/test_places/sync/test_multiple_visits_around_sync.js :: anonymous :: line 108
*** FAIL ***

Comment 1

[Justin Wood (:Callek)]

from log:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1228535940.1228538673.4893.gz&fulltext=1

NEXT ERROR TEST-UNEXPECTED-FAIL | ../../../../_tests/xpcshell-simple/test_places/sync/test_multiple_visits_around_sync.js | test failed, see log
../../../../_tests/xpcshell-simple/test_places/sync/test_multiple_visits_around_sync.js.log:
>>>>>>>
*** test pending
*** test pending
*** test finished
*** running event loop
*** exiting
NEXT ERROR *** TEST-UNEXPECTED-FAIL | ../../../../_tests/xpcshell-simple/test_places/sync/head_sync.js | false == true
JS frame :: /builds/slave/trunk_linux-8/build/tools/test-harness/xpcshell-simple/head.js :: do_throw :: line 101
JS frame :: /builds/slave/trunk_linux-8/build/tools/test-harness/xpcshell-simple/head.js :: do_check_eq :: line 120
JS frame :: /builds/slave/trunk_linux-8/build/tools/test-harness/xpcshell-simple/head.js :: do_check_true :: line 126
JS frame :: ../../../../_tests/xpcshell-simple/test_places/sync/head_sync.js :: new_test_visit_uri_event :: line 236
JS frame :: ../../../../_tests/xpcshell-simple/test_places/sync/test_multiple_visits_around_sync.js :: anonymous :: line 108
*** FAIL ***

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

thaks, those sync visits tests needs to be stronger

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.1

same changes applied to the other sync visit test

Comment 5

[Shawn Wilsher :sdwilsh]

Comment on attachment 351901 [details] [diff] [review]
patch v1.1

r=sdwilsh

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

pushed to trunk:
http://hg.mozilla.org/mozilla-central/rev/99df4df6b689

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

pushed to 1.9.1 branch:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/52081b291930