Last Comment Bug 468009 - SOAP::Lite versions greater than 0.68 and less than 0.710.06 return the wrong XML for methods
: SOAP::Lite versions greater than 0.68 and less than 0.710.06 return the wrong...
Status: RESOLVED FIXED
:
Product: Bugzilla
Classification: Server Software
Component: WebService (show other bugs)
: 3.2
: All All
: -- major (vote)
: Bugzilla 3.0
Assigned To: Max Kanat-Alexander
: default-qa
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-12-04 18:05 PST by Max Kanat-Alexander
Modified: 2008-12-06 11:59 PST (History)
0 users
mkanat: approval+
mkanat: approval3.2+
mkanat: blocking3.2.1+
mkanat: approval3.0+
mkanat: blocking3.0.7+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
v1 (667 bytes, patch)
2008-12-04 18:20 PST, Max Kanat-Alexander
LpSolit: review+
Details | Diff | Splinter Review
Sample Bad XML Response (3.31 KB, text/xml)
2008-12-04 18:24 PST, Max Kanat-Alexander
no flags Details
Sample Good XML Response (3.21 KB, text/xml)
2008-12-04 18:26 PST, Max Kanat-Alexander
no flags Details

Description Max Kanat-Alexander 2008-12-04 18:05:06 PST
I knew this bug existed, but I didn't know what versions were affected until just now. If you are using a bad version of SOAP::Lite (greater than 0.68 but before 0.710.06), then you get things like <get_bugsResponse> instead of <methodResponse> in the XML returned from method calls. Some SOAP clients might be OK with this, but I suspect that most (if not all) will actually break in this case, so we need to blacklist those SOAP::Lite versions.
Comment 1 Max Kanat-Alexander 2008-12-04 18:20:41 PST
Created attachment 351486 [details] [diff] [review]
v1
Comment 2 Frédéric Buclin 2008-12-04 18:24:12 PST
Comment on attachment 351486 [details] [diff] [review]
v1

Looks good, but I have no way to check this. r=LpSolit
Comment 3 Max Kanat-Alexander 2008-12-04 18:24:20 PST
Created attachment 351487 [details]
Sample Bad XML Response

Just so people get the idea, here's what a bad version of SOAP::Lite returns.
Comment 4 Max Kanat-Alexander 2008-12-04 18:26:52 PST
Created attachment 351489 [details]
Sample Good XML Response

And here's the same call, but with a good SOAP::Lite version.
Comment 5 Max Kanat-Alexander 2008-12-06 11:59:04 PST
tip:

Checking in Bugzilla/Install/Requirements.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Requirements.pm,v  <--  Requirements.pm
new revision: 1.53; previous revision: 1.52
done

3.2:

Checking in Bugzilla/Install/Requirements.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Requirements.pm,v  <--  Requirements.pm
new revision: 1.47.2.5; previous revision: 1.47.2.4
done

3.0:

Checking in Bugzilla/Install/Requirements.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Requirements.pm,v  <--  Requirements.pm
new revision: 1.29.2.7; previous revision: 1.29.2.6
done

Note You need to log in before you can comment on or make changes to this bug.