46802 - startup load of nsprefm.dll could be avoided

Status: VERIFIED FIXED

(Core Graveyard :: Profile: Migration, defect, P4)

Description

[Daniel Bratell]

nsprefsm.dll is loaded at each start but normally doesn't do anything. Right now 
the whole dll is loaded because 
nsPrefConverter::ConvertPrefsToUTF8IfNecessary(void) is called and (except for 
the first time run) the only thing it does is the the following:

  NS_WITH_SERVICE(nsIPref, prefs, kPrefServiceCID, &rv);
  PRBool prefs_converted = PR_FALSE;
  prefs->GetBoolPref("prefs.converted-to-utf8",&prefs_converted);
  if (prefs_converted) return NS_OK;

Couldn't that code be moved outside the dll? Maybe to somewhere near 
http://lxr.mozilla.org/seamonkey/source/profile/src/nsProfile.cpp#408
.

Comment 1

[Daniel Bratell]

I think the dll gets unloaded when used, I hope I'm right, but fixing this would 
at least decrease startup time.

Comment 2

[Daniel Veditz [:dveditz]]

This is also a footprint issue, we do *not* unload component libraries once 
loaded AFAIK. I'll take this, the suggested fix is right on and simple, no 
reason not to.

Comment 3

[Daniel Veditz [:dveditz]]

Reassign to dbragg.

Comment 4

[dbragg]

Accepting

Comment 5

[dbragg]

Fixed.  Test for need to update to UTF8 now in nsProfile.cpp so nsprefm.dll or 
.so or .shlb, whatever will only be loaded if the prefs need to be changed to 
utf8.

Comment 6

[dbragg]

Oops, Didn't mark fixed.

Comment 7

[Grace Bush]

verified code fix

Comment 8

[Daniel Bratell]

It works also. I tested with a current CVS debug build on Windows 2000 and 
nsprefm.dll is no longer loaded.