468041 - failed to build js with "--enable-dtrace"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Boying Lu]

Attachment: patch

Built latest firefox trunk codes with "--enable-dtrace",
I got following errors:
"/export/home/brian/packages/BUILD/SUNWfirefox-3.1b2/firefox/js/src/jsdtracef.h", line 36: cannot find include file: "jav     ascript-trace.h"
cc: acomp failed for /export/home/brian/packages/BUILD/SUNWfirefox-3.1b2/firefox/js/src/jsdtracef.c

Comment 1

[Benjamin Smedberg]

Comment on attachment 351522 [details] [diff] [review]
patch

This patch doesn't make much sense on the current sources: spidermonkey builds .cpp files, not .c

Comment 2

[Jim Blandy :jimb]

Comment on attachment 351522 [details] [diff] [review]
patch

I'm not sure which version of Firefox this patch is for, but on the trunk, most of js/src is C++; the patch drops the dependencies of the object files generated from C++ on javascript-trace.h.

(And I'm not a superreviewer.  :) )

Comment 3

[Jim Blandy :jimb]

Attachment: Bug 468041: List the object files that depend on javascript-trace.h explicitly.

It seems gratuitous to rebuild every object file when
javascript-trace.h changes.

Does this patch work for you?

Comment 4

[Boying Lu]

(In reply to comment #3)
> Created an attachment (id=351572) [details]
> Bug 468041: List the object files that depend on javascript-trace.h explicitly.
> 
> It seems gratuitous to rebuild every object file when
> javascript-trace.h changes.
> 
> Does this patch work for you?
Yes. it works.

Comment 5

[Benjamin Smedberg]

Comment on attachment 351572 [details] [diff] [review]
Bug 468041: List the object files that depend on javascript-trace.h explicitly.

>+$(addsuffix .$(OBJ_SUFFIX),jsdtracef jsinterp jsobj): \
>+		$(CURDIR)/javascript-trace.h

Please avoid the continuation line here: I think it's more readable to be on one line >80 chars, instead of looking at first glance like a rule command.

Comment 6

[Jim Blandy :jimb]

Landed in M-C with that change: 5748936939f4