Closed
Bug 468155
Opened 16 years ago
Closed 16 years ago
offline download button on imap folder props doesn't work
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b2
People
(Reporter: Bienvenu, Assigned: Bienvenu)
Details
(Keywords: regression)
Attachments
(1 file)
2.82 KB,
patch
|
standard8
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
If I click the download button on the offline tab of the folder properties dialog, it does nothing. Fix upcoming. The fix is to restore some of the code that the auto sync landing removed. This code is only hit when nsImapMailFolder::DownloadAllForOffline is called, which is from the folder properties dialog, and the file | offline download and sync now. I'd probably respin b1 for this, except that the auto sync should take of most peoples needs, and no one seems to have noticed this up til now...thoughts?
Flags: blocking-thunderbird3+
Attachment #351610 -
Flags: superreview?(neil)
Attachment #351610 -
Flags: review?(bugzilla)
Assignee | ||
Updated•16 years ago
|
Status: NEW → ASSIGNED
Comment 1•16 years ago
|
||
give them time :) I've never used this stuff. If someone turns off auto download I suppose theere might be a reason to hit "download now", but I can't think of anything other than to do some sort of selective offline work. is "Work offline" impacted in any way - selective or otherwise?
Assignee | ||
Comment 2•16 years ago
|
||
work offline isn't affected, other than that can kick off a download, if you've so configured it. And that download will not do anything, at least for imap. You're right that turning off auto sync would leave you rather hosed, as far as downloading for offline is concerned. On the other hand, from a UI point of view, we'd rather the user never have to explicitly download for offline use.
Updated•16 years ago
|
Attachment #351610 -
Flags: superreview?(neil) → superreview+
Updated•16 years ago
|
Attachment #351610 -
Flags: review?(bugzilla) → review+
Comment 3•16 years ago
|
||
Comment on attachment 351610 [details] [diff] [review] proposed fix thank goodness for glodaquilla. Made this much easier to test. re respining b1. I'm not convinced that having an option partially hidden away on a properties dialog not working, and the fact that we've got autosync, and can download when going offline, would really warrant a respin of b1 on its own.
Assignee | ||
Comment 4•16 years ago
|
||
You can't download imap when going offline, because of this bug. So you are forced to rely on auto sync, plus the fact that clicking on a message will download it for offline use.
Assignee | ||
Comment 5•16 years ago
|
||
fixed on trunk. A test case for this would be great - it would just need to call nsImapMailFolder::DownloadAllForOffline, listen for it to finish, and then verify that the messages were in the offline store.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Updated•16 years ago
|
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → Thunderbird 3.0b2
Comment 6•15 years ago
|
||
This FIXED bug is flagged with in‑testsuite? It would be great if assignee or someone else can clear the flag if a test is not appropriate. And if appropriate, create a test and plus the flag to finish off the bug.
Comment 7•15 years ago
|
||
BTW: I think that syncing of IMAP folders should be turned OFF by default (in Beta 1 it is set to ON by default). It may cause really big issue if you are using a GSM/UMTS internet connection, and you're paying for the amount of data downloaded! Thunderbird 3 beta 1 starts syncing of all IMAP folders w/o any prior notification to the user. Bestest, -Chris
You need to log in
before you can comment on or make changes to this bug.
Description
•