46817 - Regression -- <tabcontrol> xul element no longer displays

Status: VERIFIED FIXED

(Core :: Security, defect, P3)

Description

[Alek Jeziorek]

-start browser
-QA|Smoketests
-scroll down to the login page link in the browser test
-enter in squiddy/calamari
-log in 
-Tasks|Privacy and Security|Password Manager|View Stored Passwords
-the window is blank and very very small unless resized
Linux comm. 2000-07-28-08 ***M18***

Comment 1

[Mitchell Stoltz (not reading bugmail)]

I'm not sure who knows this code. Morse? Please reassign if I'm wrong.

Comment 2

[Stephen P. Morse]

Is this linux only?  Commercial only?  Specific to only one machine?  Did it 
work properly with yesterday's build?

Comment 3

[Alek Jeziorek]

seeing this on windows too, i don't think it was on yesterdays build though

Comment 4

[leger]

This is on Trunk build M18.  
Alek, this works ok on last commerical M17 branch yes?

Comment 5

[Alek Jeziorek]

yea the bug was not there on last build (2000-07-27-08-M17) according to those 
who checked it yesterday when i was out and also the last build i checked was ok 

Comment 6

[Stephen P. Morse]

OK, I just pulled a new tree and I'm seeing this.  It's really serious.  
Affects the cookie viewer as well.  You don't need to go through all those steps 
to reproduce -- simply go directly to the item in the tasks menu and you'll see 
the very very very small password or cookie viewer.

   tasks->privacy->password-manager->view-stored-passwords
   tasks->privacy->cookie-manager->view-stored-cookies

You mention about resizing.  That's not possible, at least not on windows.

Althought these are my menus, it's not my bug but I don't know who to reassign 
it to.  Hyatt maybe?  I'll see if I can come up with a very simple test case to 
demonstrate this.

Comment 7

[Stephen P. Morse]

OK, problem is in tabcontrol.  Here's a minimal test case to demonstrate it.  It 
displays nothing.  But using a build from a couple of days ago this works fine.

Reassigning to hyatt and changing summary line.

<?xml version="1.0"?>
<!-- CHANGE THIS WHEN MOVING FILES -->
<?xml-stylesheet href="chrome://communicator/skin/" type="text/css"?>
<?xul-overlay href="chrome://global/content/dialogOverlay.xul"?>

<!-- CHANGE THIS WHEN MOVING FILES -->
<window id="bug"
        title=""
        xmlns:html="http://www.w3.org/1999/xhtml"
        xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
        align="vertical"
        class="dialog">

  <keyset id="keyset"/>
           
  <tabcontrol flex="100%" align="vertical">
    <tabbox>
      <tab selected="true" value="Hello"/>
    </tabbox>
  </tabcontrol>
  
</window>

Comment 8

[Stephen P. Morse]

Note that there's a whole section missing in the theme's pref panel.  Same bug 
-- it also uses <tabcontrol>

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

I know what this is. I have a new tab widget in my tree and my copy of xul.css
was pointing to it. I checked in a fix for the toolbarseparator warnings the
other night and accidentally checked in rules pointing to my nonexistant tab
widget [odd, since I swear I took precautions to avoid this o_O]... I'll remove
my references for now and check in and everything should be dandy. 

Comment 10

[Alek Jeziorek]

i got a strange error on the Linux M18 2000-07-31-08 

XML Parsing Error: undefined entity
Line Number 34, Column 18:
altitle="&windowa;alttitle.label;"
-------------^

This popped up in the view password pop up instead of the normal display

Comment 11

[Stephen P. Morse]

*** Bug 46835 has been marked as a duplicate of this bug. ***

Comment 12

[Paul Chen]

nav triage team: up to nsbeta3+, we need to find out if this still happens

Comment 13

[Alek Jeziorek]

still on all platforms using m18 trunk build 2000-08-04-08-M18

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

the bug described in this report originally has been fixed. 

Comment 15

[Alek Jeziorek]

no longer see this on any platforms using build 2000-08-10-09-M18; verifying