468189 - test_bug364461.xul sporadic failures | Did not receive all expected events

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Robert Strong (they/them - no direct email)]

From the log
*** 145 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/docshell/test/chrome/test_bug364461.xul | Did not receive all expected events

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1228516414.1228520435.18294.gz&fulltext=1

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1228498457.1228501333.30801.gz&fulltext=1

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1227473134.1227477120.24875.gz&fulltext=1

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1226400132.1226405692.1196.gz&fulltext=1

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1226379511.1226385155.16217.gz&fulltext=1

Comment 1

[Boris Zbarsky [:bzbarsky]]

ccing test author.

Comment 2

[Graeme McCutcheon [:graememcc]]

Given that when it does fail, it doesn't fail consistently at the same place, is it not the code at http://mxr.mozilla.org/mozilla-central/source/docshell/test/chrome/bug364461_window.xul#82 which is to blame? 

The test will fail if it doesn't complete within 5000ms of being loaded.

Comment 3

[Sylvain Pasche]

right, that could happen if the test is running very slowly.  Possible solutions:
1. raise the timeout
2. drop the timeout so that the mochitest timeout should itself be triggered in case of failure (which should be 300 seconds http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/tests/SimpleTest/TestRunner.js#15).

2. seems to be the cleaner option.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Er, yes.  It should just depend on the main mochitest timeout, not set up its own timeout thing.

I pushed http://hg.mozilla.org/mozilla-central/rev/53f438686fa2 to remove that timeout stuff.  This should be fixed.

Comment 5

[Daniel Holbert [:dholbert]]

This test failed on a 1.9.1 tinderbox today:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.1/1235679961.1235685558.26203.gz
*** 161 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/docshell/test/chrome/test_bug364461.xul | Did not receive all expected events

bz, would it make sense to land your fix from comment 4 on the 1.9.1 branch?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Probably, yeah.  Let's do it.

Comment 7

[(not currently active) Ted Mielczarek]

This never made it to 1.9.1...

Comment 8

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)

> I pushed http://hg.mozilla.org/mozilla-central/rev/53f438686fa2

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ed26b8fbad3c