reftests/font-face/sheet-set-switch-1 fails on mac

NEW
Assigned to

Status

()

Core
Graphics
9 years ago
4 months ago

People

(Reporter: karlt, Assigned: dbaron)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Comment hidden (empty)
(Reporter)

Comment 1

9 years ago
Created attachment 351663 [details]
reference png (gtk)
(Assignee)

Comment 2

9 years ago
Hmmm.  It works for me, with your patch, though.
(Reporter)

Comment 3

9 years ago
Created attachment 351664 [details]
test png (gtk)

The C appears to be positioned 1 pixel to the left of position of the Y.

(The test passes on my system.)
(Assignee)

Comment 4

9 years ago
I guess it seems most likely to be a text run separation issue, that could probably be fixed by changing the test.

Unlikely to be fixed by the remaining patch I have in my tree (bug 458878).
This test has been failing for me and Jonathan Kew on Mac too.
(Assignee)

Comment 6

9 years ago
Er, wait, the images you attached look like sheet-set-switch-1, not sheet-set-base-1.  Which one is failing on the Linux tinderbox?   (And is it the same one that's failing on Mac for roc and Jonathan Kew?)
Sorry, I was mistaken --- it's sheet-set-switch-1 that's failing for us on Mac.
(Assignee)

Comment 8

9 years ago
It's also sheet-set-switch-1 that Karl marked random on GTK2 in the reftest.list.
Summary: reftests/font-face/sheet-set-base-1 fails on gtk → reftests/font-face/sheet-set-switch-1 fails on gtk
Can we mark sheet-set-switch-1 as random on Mac too, since it fails there for me and Jonathan?
(Assignee)

Comment 10

9 years ago
I tried running valgrind on this, and I didn't get any warnings (without the patch from bug 476724).

Bug 476724 could be the cause of the randomness on Mac.

Comment 11

9 years ago
Traced this down for bug 476724, see:

https://bugzilla.mozilla.org/show_bug.cgi?id=476724#c21

Basically the Mark2B and MarkXMark2Y fonts have differing underline offsets.  The reference would be identical if it simply uses Mark2C, MarkB and the body text 'ACB'.

Comment 12

9 years ago
Or another solution would be to explicitly set the metrics in the python script that creates the markXX fonts, then check in corrected versions of these.
(Assignee)

Comment 13

9 years ago
(In reply to comment #12)
> Or another solution would be to explicitly set the metrics in the python script
> that creates the markXX fonts, then check in corrected versions of these.

I couldn't find an API that let me do this, although changing the vertical extents of the glyphs to match fixed it.

That said, I think we could be testing useful things by having them different, so I'm inclined to scratch markXmark2Y and rewrite the references that use it.
Assignee: mozbugz → dbaron
(Assignee)

Comment 14

9 years ago
Created attachment 360821 [details] [diff] [review]
patch
Attachment #360821 - Flags: review?(jdaggett)

Updated

9 years ago
Attachment #360821 - Flags: review?(jdaggett) → review+

Comment 15

9 years ago
Comment on attachment 360821 [details] [diff] [review]
patch

Looks good.
(Assignee)

Comment 16

9 years ago
http://hg.mozilla.org/mozilla-central/rev/c592bbe68cc7
... but it still fails on Mac (should have tested on my own Mac too; I think I was doing too many things at once last night)...
http://hg.mozilla.org/mozilla-central/rev/97867f9b4e42
(Assignee)

Comment 17

9 years ago
Worse, it's actually still random on Mac (and I've seen it both ways on my Mac).
http://hg.mozilla.org/mozilla-central/rev/3362518abdc0

Comment 18

9 years ago
Pushed reftest change to 1.9.1 branch
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/434c69757f4b

Comment 19

8 years ago
Is this bug fixed?
(Assignee)

Comment 20

8 years ago
The test is still marked as random on Mac in the manifest.
(Reporter)

Updated

8 years ago
OS: Linux → Mac OS X
Summary: reftests/font-face/sheet-set-switch-1 fails on gtk → reftests/font-face/sheet-set-switch-1 fails on mac
(Reporter)

Updated

8 years ago
Attachment #351663 - Attachment description: reference png → reference png (gtk)
(Reporter)

Updated

8 years ago
Attachment #351664 - Attachment description: test png → test png (gtk)

Updated

4 months ago
See Also: → bug 1356158
You need to log in before you can comment on or make changes to this bug.