Closed Bug 468233 Opened 12 years ago Closed 12 years ago

misspelled attribute "hideifnoinsetionpoint"

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3.6a1

People

(Reporter: kairo, Assigned: mkohler)

References

()

Details

Attachments

(1 file)

When doing the review for the bug 382187 port of the history part of places to SeaMonkey, Neil spotted the misspelling "hideifnoinsetionpoint" (missing "r" in "insertion") in the comment in controller.js, but actually this attribute is misspelled all over, see http://mxr.mozilla.org/mozilla-central/search?string=hideifnoinsetionpoint

This should probably be corrected to avoid confusion.
yeah, we know about that, was also notified during the review process but still went in... Will most likely be corrected when working on that code (i also think i have a lying around patch in bugzilla that was fixing it too, but can't find actually)

thanks for notifying issues you find while adapting that code.
http://mxr.mozilla.org/mozilla-central/search?string=Dragable is another misspelling in places code, BTW.
Whiteboard: [good first bug]
Attached patch PatchSplinter Review
Had nothing to do so I made this patch.

This fixes:
"hideifnoinsetionpoint" -> "hideifnoinsertionpoint"
"Dragable" -> "Draggable" (it should be written like that, isn't it?)
Attachment #363971 - Flags: review?(mak77)
Comment on attachment 363971 [details] [diff] [review]
Patch

we can take this, thanks
Attachment #363971 - Flags: review?(mak77) → review+
Keywords: checkin-needed
Assignee: nobody → michaelkohler
Status: NEW → ASSIGNED
Whiteboard: [good first bug]
http://hg.mozilla.org/mozilla-central/rev/405ada0ccf3a
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.2a1
Comment on attachment 363971 [details] [diff] [review]
Patch

no risk, asking approval just to sync code and avoid unbitrotting.
Attachment #363971 - Flags: approval1.9.1?
Attachment #363971 - Flags: approval1.9.1? → approval1.9.1-
Comment on attachment 363971 [details] [diff] [review]
Patch

Sadly, I don't think this can be taken on branch because it changes method names that add-ons might be taking.
http://mxr-test.konigsberg.mozilla.org/addons/search?string=getDragableSelection

shows that AMO addons with IDs 6759, 6545, 424, 3615, 6271 call that method. It would be nice to give them a heads up to let them know they might need to update their addons for trunk compatibility.
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.