468314 - rounded borders drawing artifacts when the width is changed dynamically

Status: VERIFIED WORKSFORME

(Core :: Layout, defect)

Description

[Ulf Ochsenfahrt]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.4) Gecko/2008111318 Ubuntu/8.10 (intrepid) Firefox/3.0.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.4) Gecko/2008111318 Ubuntu/8.10 (intrepid) Firefox/3.0.4

When the width of an element with rounded borders (-moz-border-radius) is changed dynamically, drawing artifacts can be seen sometimes.

Reproducible: Sometimes

Steps to Reproduce:
1. Open attached html file.
2. Click on slider and drag left and right.
Actual Results:  
Redraw isn't always performed correctly, see attached screenshot. The artifacts vanish on the next redraw, e.g., by clicking on another window, or clicking on the slider again.

Expected Results:  
Redraw should always be correct.

Comment 1

[Ulf Ochsenfahrt]

Attachment: An html page exhibiting the bug (needs gradient.png!).

Comment 2

[Ulf Ochsenfahrt]

Attachment: Gradient image; part of the test html page.

Comment 3

[Ulf Ochsenfahrt]

Attachment: Screenshot that diesplays the incorrect redraw behavior.

Comment 4

[Ria Klaassen (not reading all bugmail)]

Confirmed on Windows XP. 
Regressed between 2007121800 and 2007121900.
Regression window is: http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2007-12-17+22%3A00&maxdate=2007-12-19+02%3A00
Caused by Bug 24998 or Bug 406458?
I see also that it continues dragging after mouse up but I think this is a different bug

Comment 5

[Ria Klaassen (not reading all bugmail)]

Well it is bug 24998.

Comment 6

[Ria Klaassen (not reading all bugmail)]

Easiest way to reproduce is clicking in the gray part.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mmh, that's strange. It doesn't react on mouse clicks at all on OS X. I only see a gray bar.

Comment 8

[Alfred Kayser]

It is not the border radius drawing itself that is the problem, 
but the 'dirty rect' calculation. The change of the width of the inner div (#light) doesn't force redraw of the correct piece.

Comment 9

[philippe (part-time)]

Attachment: standalone testcase

data uri !
Repro'd on OS X both Minefield latest and Gecko 1.9.0.6pre. Somehow it is worse on Minefield

Comment 10

[Ulf Ochsenfahrt]

The standalone testcase is much nicer. :-)

Comment 11

[Bryan]

Double clicking in the gray area in the standalone test-case https://bugzilla.mozilla.org/attachment.cgi?id=351766 seems to remove the artifacts and forces a correct re-draw unless I'm completely not understanding this bug.

~B

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

WFM on Mac trunk. Fixed?

Comment 13

[philippe (part-time)]

(In reply to comment #12)
> WFM on Mac trunk. Fixed?
Latest Linux Minefield works fine here.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090719 Minefield/3.6a1pre ID:20090719031543