Closed Bug 468443 Opened 11 years ago Closed 11 years ago

Remove PUT/DELETE support from httpd.js

Categories

(Testing :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mayhemer, Assigned: mayhemer)

References

Details

Attachments

(3 files, 1 obsolete file)

Originally introduced in bug 443610. It breaks some thinks and apparently doesn't conform the spec. The original purpose has been altered by SJS full state support.
Component: Mochitest → httpd.js
QA Contact: mochitest → httpd.js
Blocks: 411530
This patch removes the PUT and DELETE capability from httpd.js.
Attachment #355632 - Flags: review?(jwalden+bmo)
This is reversion of the XX hack to allow cross-site XHR tests for PUT and DELETE methods. Both tests run and pass.
Attachment #355633 - Flags: review?(jonas)
Comment on attachment 355632 [details] [diff] [review]
remove PUT/DELETE from httpd.js [Checked-in comment 7][Checked-in comment 12 on 1.9.1]

Looks good to me, if it works it's golden.
Attachment #355632 - Flags: review?(jwalden+bmo) → review+
Comment on attachment 355633 [details] [diff] [review]
revert XXDELETE and XXPUT from XHR XS tests

Looks great, but I messed around a bit with the tests so you'll have to do a new search'n'replace.

You've also missed at least one "XXDELETE" (search for "XXDELETEZ" in the patch).

Just search for XXDELETE and XXPUT everywhere and remove the XX.

Or let me know if you'd rather that I did it given that I bitrotted your patch so heavily.
Attachment #355633 - Flags: review?(jonas) → review+
(In reply to comment #4)
> (From update of attachment 355633 [details] [diff] [review])
> Looks great, but I messed around a bit with the tests so you'll have to do a
> new search'n'replace.
> 
> You've also missed at least one "XXDELETE" (search for "XXDELETEZ" in the
> patch).
> 
> Just search for XXDELETE and XXPUT everywhere and remove the XX.
> 

Updated patch. Curious is that the tests passed with leaving the XXDELETEZ.
Attachment #355633 - Attachment is obsolete: true
Attachment #360372 - Flags: review+
> Updated patch. Curious is that the tests passed with leaving the XXDELETEZ.

It'll work fine as long as you use anything other than "DELETE" there. So "DELETEZ", "XXDELETEZ", or "SUGARCOOKIE" should all behave the same.

However I wanted to test that we were doing the right thing with something that was almost the same as "DELETE".
Blocks: 396226
http://hg.mozilla.org/mozilla-central/rev/2bc7dfa8bbf6
http://hg.mozilla.org/mozilla-central/rev/0c9af8ac1a41
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attachment #355632 - Attachment description: remove PUT/DELETE from httpd.js → remove PUT/DELETE from httpd.js [Checked-in comment 7]
Attachment #360372 - Attachment description: revert XXDELETE and XXPUT from XHR XS tests, v1.1 → revert XXDELETE and XXPUT from XHR XS tests, v1.1 [Checked-in comment 7]
Would be great to get this ported to branch. Just ended up wasting a couple of hours due to having to back out a patch landed on branch (which had worked fine on m-c) and then figure out what had gone wrong.
(I care less about getting the fixes for the XS-XHR tests landed, that's easily detected during merge)
Whiteboard: [needs 1.9.1 landing]
Attachment #364690 - Attachment description: [Checkin comment 10 on 1.9.1] → [Checkin comment 11 on 1.9.1]
Whiteboard: [needs 1.9.1 landing]
Comment on attachment 355632 [details] [diff] [review]
remove PUT/DELETE from httpd.js [Checked-in comment 7][Checked-in comment 12 on 1.9.1]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b5b24d83b13a
Attachment #355632 - Attachment description: remove PUT/DELETE from httpd.js [Checked-in comment 7] → remove PUT/DELETE from httpd.js [Checked-in comment 7][Checked-in comment 12 on 1.9.1]
Component: httpd.js → General
You need to log in before you can comment on or make changes to this bug.