468443 - Remove PUT/DELETE support from httpd.js

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Honza Bambas (:mayhemer)]

Originally introduced in bug 443610. It breaks some thinks and apparently doesn't conform the spec. The original purpose has been altered by SJS full state support.

Comment 1

[Honza Bambas (:mayhemer)]

Attachment: remove PUT/DELETE from httpd.js [Checked-in comment 7][Checked-in comment 12 on 1.9.1]

This patch removes the PUT and DELETE capability from httpd.js.

Comment 2

[Honza Bambas (:mayhemer)]

Attachment: revert XXDELETE and XXPUT from XHR XS tests

This is reversion of the XX hack to allow cross-site XHR tests for PUT and DELETE methods. Both tests run and pass.

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 355632 [details] [diff] [review]
remove PUT/DELETE from httpd.js [Checked-in comment 7][Checked-in comment 12 on 1.9.1]

Looks good to me, if it works it's golden.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 355633 [details] [diff] [review]
revert XXDELETE and XXPUT from XHR XS tests

Looks great, but I messed around a bit with the tests so you'll have to do a new search'n'replace.

You've also missed at least one "XXDELETE" (search for "XXDELETEZ" in the patch).

Just search for XXDELETE and XXPUT everywhere and remove the XX.

Or let me know if you'd rather that I did it given that I bitrotted your patch so heavily.

Comment 5

[Honza Bambas (:mayhemer)]

Attachment: revert XXDELETE and XXPUT from XHR XS tests, v1.1 [Checked-in comment 7]

(In reply to comment #4)
> (From update of attachment 355633 [details] [diff] [review])
> Looks great, but I messed around a bit with the tests so you'll have to do a
> new search'n'replace.
> 
> You've also missed at least one "XXDELETE" (search for "XXDELETEZ" in the
> patch).
> 
> Just search for XXDELETE and XXPUT everywhere and remove the XX.
> 

Updated patch. Curious is that the tests passed with leaving the XXDELETEZ.

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

> Updated patch. Curious is that the tests passed with leaving the XXDELETEZ.

It'll work fine as long as you use anything other than "DELETE" there. So "DELETEZ", "XXDELETEZ", or "SUGARCOOKIE" should all behave the same.

However I wanted to test that we were doing the right thing with something that was almost the same as "DELETE".

Comment 7

[Honza Bambas (:mayhemer)]

http://hg.mozilla.org/mozilla-central/rev/2bc7dfa8bbf6
http://hg.mozilla.org/mozilla-central/rev/0c9af8ac1a41

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Would be great to get this ported to branch. Just ended up wasting a couple of hours due to having to back out a patch landed on branch (which had worked fine on m-c) and then figure out what had gone wrong.

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

(I care less about getting the fixes for the XS-XHR tests landed, that's easily detected during merge)

Comment 10

[Honza Bambas (:mayhemer)]

Attachment: [Checkin comment 11 on 1.9.1]

Comment 11

[Honza Bambas (:mayhemer)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c7a4b54d20cb

Comment 12

[Honza Bambas (:mayhemer)]

Comment on attachment 355632 [details] [diff] [review]
remove PUT/DELETE from httpd.js [Checked-in comment 7][Checked-in comment 12 on 1.9.1]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b5b24d83b13a