Closed Bug 468444 Opened 11 years ago Closed 11 years ago

Make definitions for default port constants on our various protocols consistent and accessible from script

Categories

(MailNews Core :: Backend, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Attached patch The fixSplinter Review
At the moment our default port constants are a mixture of idl constants, c++ #defines in idl files, c++ #defines in other places. In doing the password manager code, I'm looking into moving bits of code to js, and we should really just have these consistent in their use.

Attaching patch which makes all of these consistent in appropraite idl files, I went with DEFAULT_<protocol>_PORT as I thought that made it clearer that its the default port for the protocol, not the port we always use.

I also removed a couple of totally unnecessary c++ only includes in an idl file (as I was touching it) which resulted in adding includes in other places.
Attachment #351898 - Flags: superreview?(neil)
Attachment #351898 - Flags: review?(neil)
Attachment #351898 - Flags: superreview?(neil)
Attachment #351898 - Flags: superreview+
Attachment #351898 - Flags: review?(neil)
Attachment #351898 - Flags: review+
Patch checked in: http://hg.mozilla.org/comm-central/rev/1b1c9e4ebf3d
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.