Make definitions for default port constants on our various protocols consistent and accessible from script

RESOLVED FIXED in Thunderbird 3.0b2

Status

MailNews Core
Backend
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 3.0b2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

12.07 KB, patch
neil@parkwaycc.co.uk
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
Created attachment 351898 [details] [diff] [review]
The fix

At the moment our default port constants are a mixture of idl constants, c++ #defines in idl files, c++ #defines in other places. In doing the password manager code, I'm looking into moving bits of code to js, and we should really just have these consistent in their use.

Attaching patch which makes all of these consistent in appropraite idl files, I went with DEFAULT_<protocol>_PORT as I thought that made it clearer that its the default port for the protocol, not the port we always use.

I also removed a couple of totally unnecessary c++ only includes in an idl file (as I was touching it) which resulted in adding includes in other places.
Attachment #351898 - Flags: superreview?(neil)
Attachment #351898 - Flags: review?(neil)

Updated

10 years ago
Attachment #351898 - Flags: superreview?(neil)
Attachment #351898 - Flags: superreview+
Attachment #351898 - Flags: review?(neil)
Attachment #351898 - Flags: review+
(Assignee)

Comment 1

10 years ago
Patch checked in: http://hg.mozilla.org/comm-central/rev/1b1c9e4ebf3d
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.