Closed Bug 468553 Opened 16 years ago Closed 16 years ago

Dragging tab to bookmarks sidebar should bookmark not tear it (3.1b2)

Categories

(Firefox :: Tabbed Browser, defect, P2)

Product:
Firefox
Component:
Tabbed Browser
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 3.6a1

People

(Reporter: magnetfastlane, Assigned: asaf)

References

Details

(Keywords: regression, verified1.9.1, Whiteboard: [fixed by bug 471499]) 

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2

The summary basically says everything. I think it's very convenient (especially on a widescreen monitor) to open the (original) bookmarks sidebar and drag a tab to the designated folder (a bit faster that double-clicking the star). ATM it just tears the page to a new window (even tho there's plenty of content space for that).

Please let me drag my tabs to bookmarks :)

Reproducible: Always

Steps to Reproduce:
1.Open the bookmarks sidebar (ctrl+b)
2.Grab the tab
3.Drag it to the sidebar
Actual Results:  
4.Tab gets teared

Expected Results:  
4.Tab gets bookmarked to the right folder
Version: unspecified → 3.1 Branch
I meant this with bug 465332, but it got morphed, so confirming rather than duping for now.
Blocks: 225680
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Version: 3.1 Branch → Trunk
Component: Toolbars → Tabbed Browser
Keywords: regression
QA Contact: toolbars → tabbed.browser
Hardware: PC → All
I would hope that they'd be fixed together, along with other similar issues, but the other bug no longer seems to cover this, so I guess this should also be a blocker...
Flags: blocking-firefox3.1?
Flags: blocking-firefox3.1? → blocking-firefox3.1+
Depends on: 465184
Depends on: 471499
This should be fixed by the patch in bug 465332, so I'm going to mark the dependency.
Depends on: 465332
Priority: -- → P2
Whiteboard: [fixed by bug 465332?]
Bug 465332 isn't fixed yet. Lets wait...
Whiteboard: [fixed by bug 465332?] → [will be fixed by bug 465332?]
Assignee: nobody → mano
Whiteboard: [will be fixed by bug 465332?] → [to be fixed by 471499]
Whiteboard: [to be fixed by 471499] → [patch on bug 471499][to be fixed by 471499]
Has this been fixed by bug 471499?
Fixed for me on:

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.1b3pre) Gecko/20090123 Shiretoko/3.1b3pre ID:20090123031537
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Verified on trunk and 1.9.1 with:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090125
Shiretoko/3.1b3pre (.NET CLR 3.5.30729) ID:20090125052901

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre)
Gecko/20090126 Shiretoko/3.1b3pre Ubiquity/0.1.5 ID:20090126020313

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090125
Minefield/3.2a1pre ID:20090125034316

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre)
Gecko/20090126 Minefield/3.2a1pre ID:20090126020316
Status: RESOLVED → VERIFIED
Flags: in-litmus?
Keywords: fixed1.9.1 → verified1.9.1
Whiteboard: [patch on bug 471499][to be fixed by 471499] → [fixed by bug 471499]
Target Milestone: --- → Firefox 3.2a1
Test case https://litmus.mozilla.org/show_test.cgi?id=7488 was added to litmus for regression testing on 3.1 test run.
Flags: in-litmus? → in-litmus+
You need to log in before you can comment on or make changes to this bug.