46870 - nsIWebNavigation::LoadURI() needs to accept a post stream.

Status: VERIFIED DUPLICATE of bug 94205

(Core Graveyard :: Embedding: APIs, defect, P3)

Description

[Judson Valeski]

-Requirement for a way to Get the post data from a form in the current document 
-Specify the post data as a parameter to LoadURI 
-Doug says that the work might already be done. Thread in n.p.m.embedding 
related to this. 
-Need a public API for getting and setting post data.

Comment 1

[Eric Pollmann]

CC'ing Radha - did you already do work in this area to get session history to
store the post data for URL's?

Comment 2

[Kevin McCluskey (gone)]

Marking nsbeta3-

Comment 3

[Radha on family leave (not reading bugmail)]

SessionHistory already stores postdata for urls. But I think this may be related 
to 32293. 32293 is nsbeta3+. So I would like know that this bug's real intention 
was, so that we can decide if this can be nsbeta3-  or +.

Comment 4

[Eric Pollmann]

Jud, is there any specific work that needs to be done in the beta3 time frame? 
nsbeta3- == Future, setting milestone to that unless I hear otherwise

Comment 5

[Kevin McCluskey (gone)]

Set milestone to mozilla0.8

Comment 6

[Paul Wyskoczka]

Updating QA Contact

Comment 7

[Kevin McCluskey (gone)]

Moving to Mozilla0.9

Comment 8

[Judson Valeski]

*** Bug 68590 has been marked as a duplicate of this bug. ***

Comment 9

[Michael Dunn]

Correction: Changing QA contact for the Embed API bugs to David Epstein.

Comment 10

[Eric Pollmann]

Attachment: patch 1

Comment 11

[Eric Pollmann]

This patch allows a post stream to be passed into nsIWebNavigation::LoadURI().
It does *not* address the other stated need of this bug, to "Get the post data
from a form in the current document".  Jud, can you provide an explanation of
what is meant by this?  Do you mean the postdata that was sent to the server to
get the current page (if it was the result of a post)?  Do you mean you want to
save the state of form controls of a given form / all forms on the current page?
 ???

CC'ing Adam because the meat of this change so far is in the DocShell and it's APIs.

I don't know/remember what this was needed for, but just as a reminder, posting
the same form twice to the server can be dangerous and the user should always be
warned and given a chance to cancel this operation before it happens!

Comment 12

[Adam Lock]

Changes look good, except for those to the internal version of LoadURI. Would it 
make sense to make postdata a member of the loadinfo object rather than an extra 
parameter?

Comment 13

[Eric Pollmann]

Attachment: patch 2

Comment 14

[Eric Pollmann]

Adam, patch 2 removes the new param from the internal LoadURI and adds a
postDataStream member to the load info, as you suggest.  Does this look better?

Comment 15

[Eric Pollmann]

Attachment: patch 3 - only create loadinfo if aPostDataStream is set in LoadURI

Comment 16

[Adam Lock]

Looks good, r=adamlock

Comment 17

[Boris Zbarsky [:bzbarsky]]

The patch needs to be updated a bit...  For one thing, we now have
nsDocShellLoadInfo::GetPostDataStream and nsDocShellLoadInfo::SetPostDataStream
 so this patch doesn't have to create them....

Comment 18

[Blake Ross]

Didn't make 0.9.3.

Comment 19

[rpotts (gone)]

This work is now being tracked by bug #94205.

*** This bug has been marked as a duplicate of 94205 ***

Comment 20

[David Epstein]

verifying as dupe of bug 94205.