The Persian installer's UI should be RTL.

VERIFIED FIXED in mozilla1.9.2a1

Status

()

Toolkit
NSIS Installer
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Away for a while, Assigned: Away for a while)

Tracking

({verified1.9.1})

Trunk
mozilla1.9.2a1
verified1.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 352196 [details] [diff] [review]
Make fa installer RTL
Attachment #352196 - Flags: review?(l10n)

Updated

9 years ago
Attachment #352196 - Flags: review?(l10n)

Comment 1

9 years ago
Comment on attachment 352196 [details] [diff] [review]
Make fa installer RTL

Mind putting this back into my review queue when we have the unicode installer up? I don't think it makes sense to review this patch before that.
(Assignee)

Comment 2

9 years ago
(In reply to comment #1)
> (From update of attachment 352196 [details] [diff] [review])
> Mind putting this back into my review queue when we have the unicode installer
> up? I don't think it makes sense to review this patch before that.

Sure, will do.
Comment on attachment 352196 [details] [diff] [review]
Make fa installer RTL

For what it is worth this patch has my r+ and can be checked in after the Unicode installer lands and the Persian locale files for the installer lands
(Assignee)

Comment 4

9 years ago
Comment on attachment 352196 [details] [diff] [review]
Make fa installer RTL

Great.  For technical correctness, could you mark r+ on the patch as well?
Attachment #352196 - Flags: review?(robert.bugzilla)
Comment on attachment 352196 [details] [diff] [review]
Make fa installer RTL

No problem... I know you already know this but please don't check this in until the Unicode installer and the Persian installer locale files are checked in
Attachment #352196 - Flags: review?(robert.bugzilla) → review+
(Assignee)

Comment 6

9 years ago
(In reply to comment #5)
> (From update of attachment 352196 [details] [diff] [review])
> No problem... I know you already know this but please don't check this in until
> the Unicode installer and the Persian installer locale files are checked in

Sure.  Do I need approval for this for 1.9.1 as well?  Patches in the l10n component don't seem to have approval flags enabled...
Since this touches toolkit code let's move this over to Toolkit -> NSIS Installer so there is a 1.9.1 approval flag for this
Assignee: ehsan.akhgari → nobody
Component: fa / Persian → NSIS Installer
Product: Mozilla Localizations → Toolkit
QA Contact: persian.fa → nsis.installer
Version: unspecified → 1.9.1 Branch
Comment on attachment 352196 [details] [diff] [review]
Make fa installer RTL

Drivers, this is a change to toolkit code for the Persian locales installer's RTL setting and is an extremely simple patch.
Attachment #352196 - Flags: approval1.9.1?
Assignee: nobody → ehsan.akhgari
Comment on attachment 352196 [details] [diff] [review]
Make fa installer RTL

a191=beltzner
Attachment #352196 - Flags: approval1.9.1? → approval1.9.1+
(Assignee)

Comment 10

9 years ago
Checked in on trunk: <http://hg.mozilla.org/mozilla-central/rev/6e089951b915>

Check in on 1.9.1: <http://hg.mozilla.org/releases/mozilla-1.9.1/rev/1d485fd75e5d>
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: fixed1.9.1
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Version: 1.9.1 Branch → Trunk
(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 352196 [details] [diff] [review] [details])
> > No problem... I know you already know this but please don't check this in until
> > the Unicode installer and the Persian installer locale files are checked in
> 
> Sure.  Do I need approval for this for 1.9.1 as well?  Patches in the l10n
> component don't seem to have approval flags enabled...
I see the locales.nsi check in... has the installer's locale files been checked in?
(Assignee)

Comment 12

9 years ago
(In reply to comment #11)
> I see the locales.nsi check in... has the installer's locale files been checked
> in?

Yes:

http://hg.mozilla.org/l10n-central/fa/rev/4b95a0754f59
http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/fa/rev/3a9f1f483dd7
Verified fixed with the fa 3.5.1 installer.
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in before you can comment on or make changes to this bug.