468729 - reintroduce elastic "snapping" in and out of the sidebars

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

The sidebars (control strip and tab area) should snap into and out of place.  A starter rule we should use for this is that the user should have to drag past 2/3 of the sidebar's width for it to snap all the way into view.  To have it snap back out of view, the user should have to swipe it only 1/3 of its width out of view.  In other words, it will be easier to get rid of them than to bring them into view.

Ideally, they would also slide (rather than just appearing) when they snap into or out of view, but we can do this later, too.

Comment 1

[Stuart Parmenter]

Attachment: v0.75

this fixes it, but i'm not super happy with the function names, hard coded widths or location of this code.  will play around with changing it up a bit

Comment 2

[Stuart Parmenter]

Attachment: v1.0

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 354208 [details] [diff] [review]
v1.0

Looks fine, just fix the extra visibleRect check like we talked about on irc (either way's fine)

Comment 4

[Stuart Parmenter]

fixed

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2b1pre) Gecko/20091002
Fennec/1.0b4

and

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/200910002
Fennec/1.0b4