468768 - Ads that used to load properly, causes webpage flash to refresh itself when ad loads

Status: RESOLVED INCOMPLETE

(Core :: Layout, defect)

Description

[visualbrains]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.4) Gecko/2008102920 Firefox/3.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.4) Gecko/2008102920 Firefox/3.0.4

My blog didn't have any issue till I updated to 3.0.4 
My Ads are intentionally delayed and called in later using changenode()
This worked fine previously and is still working fine in IE 6.

However once I changed to 3.0.4, when the ads load in, it will cause the webpage to blink and reloads all flash files on my web.

Please take a look at my webpage http://reviewkaki.blogspot.com

Reproducible: Always

Steps to Reproduce:
1.go to my webpage http://reviewkaki.blogspot.com
2.wait for ad to load
3.notice it blinks when it loads
Actual Results:  
Webpage reloads each time ad loads

Expected Results:  
It shouldn't have reloaded my webpage

Comment 1

[Ria Klaassen (not reading all bugmail)]

Yeah, this looks really bad. This is a regression from Firefox 2.
Regression range: 2007081516 - 2007081516 (both the same ID).
Bonsai link:  http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2007-08-15+13%3A00&maxdate=2007-08-15+18%3A00
So possibly caused by Bug 390425.
When it first regressed the color of the flashes was different, first green, later on the flashes became deeper.

Comment 2

[Ria Klaassen (not reading all bugmail)]

The bug occurs both on Windows XP and Vista.

Comment 3

[Martijn Wargers (dead)]

Attachment: testcase

Thanks for the regression range, Ria.

Comment 4

[Boris Zbarsky [:bzbarsky]]

So... this used to "work" due to a bug, as far as I can tell: removing the <div> didn't reframe the containing block.  You can see the bug by comparing the rendering of 

data:text/html,<span id="a" style="border: 1px solid green">a<div></div>b</span><script>document.body.offsetWidth; var n = document.getElementById("a"); n.removeChild(n.childNodes[1]);</script>

in Gecko 1.9 (correct rendering) and Gecko 1.8 (incorrect rendering).

So in 1.9 and later, we reframe the containing block on this change, and in the testcase the containing block is the body.  Since plug-ins are loaded from frames, you get the observed behavior.

Marking dependent on the "load plug-ins from content" bug, but as a workaround you could put a <div> around the <span> in question.  Or in general not put blocks inside inlines (esp. since that's not valid HTML).

For what it's worth, I don't think this should block.

Comment 5

[John Schoenick [:johns]]

Is this still an issue? Plugins have long since been moved to content and a few bugs have been fixed to ensure reparenting of plugins is handled according to the spec.

Comment 6

[Phoenix]

Resolved per whiteboard