468810 - Make "Manage search engines" window resizable

Status: VERIFIED FIXED

(Firefox :: Search, enhancement)

Description

[Franz Erlendorf]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2

I have a lot of search engines installed, so I want to resize the window to see them all at once. This is currently not possible.

Reproducible: Always

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Resizing works on OS X and Linux. Windows is the only OS where the dialog is not resizable. Confirming with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a2pre) Gecko/20090825 Namoroka/3.6a2pre (.NET CLR 3.5.30729) ID:20090825052618

Ryan, is this more a theme issue? Shall we move the component?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

No, it's not a theme issue. Just need to change the window.open parameters, I think.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

See http://hg.mozilla.org/mozilla-central/annotate/d7eeee024ebf/browser/components/search/content/search.xml#l433

Comment 4

[Jae-Seong Lee-Russo]

Attachment: Make "Manage Search Engine List" window resizable

Tested on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20090926 Minefield/3.7a1pre (.NET CLR 3.5.30729)

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Lusian, you would have to ask for review from e.g. Gavin or Ryan Flint.

Comment 6

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Review in patch form

Sorry for the delay - thanks for the patch!

Comment 7

[Ryan Flint [:rflint] (ping via IRC for reviews)]

http://hg.mozilla.org/mozilla-central/rev/9e1011e38697

Comment 8

[u88484]

Verified fixed using Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a2pre) Gecko/20100212 Minefield/3.7a2pre